Merge lp:~frankban/python-shelltoolbox/apt-and-run into lp:python-shelltoolbox
Proposed by
Francesco Banconi
Status: | Merged |
---|---|
Approved by: | Gary Poster |
Approved revision: | 15 |
Merged at revision: | 15 |
Proposed branch: | lp:~frankban/python-shelltoolbox/apt-and-run |
Merge into: | lp:python-shelltoolbox |
Diff against target: |
97 lines (+37/-3) 3 files modified
setup.py (+1/-1) shelltoolbox/__init__.py (+4/-2) tests.py (+32/-0) |
To merge this branch: | bzr merge lp:~frankban/python-shelltoolbox/apt-and-run |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gary Poster (community) | Approve | ||
Review via email: mp+98188@code.launchpad.net |
Description of the change
== Changes ==
The helper *apt_get_install* now accepts a *caller* keyword argument that defaults to *run*.
This is required by lpsetup, and this way we can easily test the function too.
Fixed a problem in *run* helper error handling: calling an invalid command and passing stdout (or stderr) = None resulted in a concatenation of str and None.
Bumped version up a little.
== Tests ==
$ python tests.py
.......
-------
Ran 59 tests in 0.147s
OK
To post a comment you must log in.
Nice changes. Thank you.