Merge lp:~fourdollars/ubuntu/vivid/partman-efi/1512589 into lp:ubuntu/vivid/partman-efi

Proposed by Shih-Yuan Lee
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp:~fourdollars/ubuntu/vivid/partman-efi/1512589
Merge into: lp:ubuntu/vivid/partman-efi
Diff against target: 70 lines (+39/-4)
2 files modified
debian/changelog (+6/-0)
fstab.d/efi (+33/-4)
To merge this branch: bzr merge lp:~fourdollars/ubuntu/vivid/partman-efi/1512589
Reviewer Review Type Date Requested Status
Sebastien Bacher Disapprove
Review via email: mp+276495@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the work. How much do you need that in vivid? The current stable is in wily, it's likely enough to fix in trusty and wily, rejecting for vivid but feel free to reopen if you feel like that really needs to be resolved in vivid as well

review: Disapprove

Unmerged revisions

31. By Shih-Yuan Lee

Follow partman-auto/disk to reuse the ESP. (LP: #1512589)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2015-04-15 17:53:39 +0000
+++ debian/changelog 2015-11-03 07:09:30 +0000
@@ -1,3 +1,9 @@
1partman-efi (62ubuntu2.1) vivid-proposed; urgency=medium
2
3 * Follow partman-auto/disk to reuse the ESP. (LP: #1512589)
4
5 -- Shih-Yuan Lee (FourDollars) <sylee@canonical.com> Tue, 03 Nov 2015 14:50:38 +0800
6
1partman-efi (62ubuntu2) vivid; urgency=medium7partman-efi (62ubuntu2) vivid; urgency=medium
28
3 * Honor preseeding of partman-efi/non_efi_system (and/or don't ask for it9 * Honor preseeding of partman-efi/non_efi_system (and/or don't ask for it
410
=== modified file 'fstab.d/efi'
--- fstab.d/efi 2015-02-02 19:01:37 +0000
+++ fstab.d/efi 2015-11-03 07:09:30 +0000
@@ -12,19 +12,48 @@
12 ;;12 ;;
13esac13esac
1414
15seen_efi=15paths=
16for dev in $DEVICES/*; do16for dev in $DEVICES/*; do
17 [ -d $dev ] || continue17 [ -d $dev ] || continue
18 cd $dev18 cd $dev
19 open_dialog PARTITIONS19 open_dialog PARTITIONS
20 while { read_line num id size type fs path name; [ "$id" ]; }; do20 while { read_line num id size type fs path name; [ "$id" ]; }; do
21 [ -z "$seen_efi" ] || continue
22 [ $fs != free ] || continue21 [ $fs != free ] || continue
23 [ -f "$id/method" ] || continue22 [ -f "$id/method" ] || continue
24 method=$(cat $id/method)23 method=$(cat $id/method)
25 [ "$method" = efi ] || continue24 [ "$method" = efi ] || continue
26 echo "$path" /boot/efi vfat umask=0077 0 125 if [ -z "$paths" ]; then
27 seen_efi=126 paths="$path"
27 else
28 paths="$paths $path"
29 fi
28 done30 done
29 close_dialog31 close_dialog
30done32done
33
34if [ -z "$paths" ]; then
35 exit 0
36fi
37
38# Use any autopartition disk that has been set
39if db_get partman-auto/disk && [ "$RET" ]; then
40 disks="$RET"
41 seen_efi=
42 for disk in $disks; do
43 for path in $paths; do
44 case "$path" in
45 $disk*)
46 echo "$path" /boot/efi vfat umask=0077 0 1
47 seen_efi=1
48 break
49 ;;
50 esac
51 done
52 [ -z "$seen_efi" ] || break
53 done
54else
55 for path in $paths; do
56 echo "$path" /boot/efi vfat umask=0077 0 1
57 break
58 done
59fi

Subscribers

People subscribed via source and target branches

to all changes: