Merge lp:~fginther/adt-continuous-deployer/beefier-testbeds into lp:adt-continuous-deployer
Proposed by
Francis Ginther
Status: | Needs review |
---|---|
Proposed branch: | lp:~fginther/adt-continuous-deployer/beefier-testbeds |
Merge into: | lp:adt-continuous-deployer |
Diff against target: |
12 lines (+1/-1) 1 file modified
mojo.py (+1/-1) |
To merge this branch: | bzr merge lp:~fginther/adt-continuous-deployer/beefier-testbeds |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Celso Providelo (community) | Approve | ||
Review via email: mp+257110@code.launchpad.net |
Commit message
Use cpu2-ram2-disk50 (instead of cpu2-ram2-disk10) as default flavor for testbeds.
Description of the change
Use cpu2-ram2-disk50 (instead of cpu2-ram2-disk10) as default flavor for testbeds.
Resolves
- https:/
To post a comment you must log in.
Unmerged revisions
- 39. By Francis Ginther
-
Use cpu2-ram2-disk50 (instead of cpu2-ram2-disk10) as default flavor for testbeds.
Francis,
Looks good, but configuration flavor only affects core-image-testing solution, adt-cloud-worker uses a dedicated method to calculate suitable flavors using nova API (_cloud_ support/ get_default_ testbed_ flavor) with 'cpu2-ram2-disk10' hardcoded as fallback.
The simplest way a see to get this solved is to submit another MP for adt-cloud-worker to replace the hardcoded value with the configuration one. Although, the whole flavor-logic is unnecessary IMO and we should simply use whatever is defined in the configuration.
Anyway, this fix is perfectly fine and effective for core-image-testing, so I am approving it.