Merge lp:~fazerlicourice/ubuntu-weather-app/add-test-switch-data-providers into lp:ubuntu-weather-app
Proposed by
Vamshi Balanaga
Status: | Needs review |
---|---|
Proposed branch: | lp:~fazerlicourice/ubuntu-weather-app/add-test-switch-data-providers |
Merge into: | lp:ubuntu-weather-app |
Diff against target: |
333 lines (+173/-10) 6 files modified
AUTHORS (+2/-1) app/components/DayDelegateExtraInfo.qml (+2/-0) app/ui/settings/DataProviderPage.qml (+7/-1) debian/changelog (+3/-0) tests/autopilot/ubuntu_weather_app/__init__.py (+48/-2) tests/autopilot/ubuntu_weather_app/tests/test_settings_page.py (+111/-6) |
To merge this branch: | bzr merge lp:~fazerlicourice/ubuntu-weather-app/add-test-switch-data-providers |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrew Hayzen | Needs Fixing | ||
Jenkins Bot | continuous-integration | Needs Fixing | |
Nicholas Skaggs | Pending | ||
Review via email: mp+283749@code.launchpad.net |
Commit message
Added a test that confirms that the app correctly switches data providers.
Keys need to be present while testing for this to work.
Description of the change
Added a test that confirms that the app correctly switches data providers.
Keys need to be present while testing for this to work.
To post a comment you must log in.
Unmerged revisions
- 221. By Vamshi Balanaga <email address hidden>
-
merged upstream
- 220. By Vamshi Balanaga <email address hidden>
-
still attempting to revert the CMake file
- 219. By Vamshi Balanaga <email address hidden>
-
merged from master
- 218. By Vamshi Balanaga <email address hidden>
-
attempted to revert CMake.txt.user file
- 217. By Vamshi Balanaga <email address hidden>
-
merged from ubuntu weather app and fixed conflicts
- 216. By Vamshi Balanaga <email address hidden>
-
made requested changes.
- 215. By Vamshi Balanaga <email address hidden>
-
fixed pep8
- 214. By Vamshi Balanaga <email address hidden>
-
removed stuff
- 213. By Vamshi Balanaga <email address hidden>
-
removed code from seperate branch
- 212. By Vamshi Balanaga <email address hidden>
-
Added test to switch between data providers and verify that it executed correctly (LP: #1452489)
I won't probably be able to review this until tomorrow. However, you are correct in that you need a TWC key. The weather devs can explain it better than I.