Merge lp:~facundo/magicicada-server/incorporate-client-with-venv into lp:magicicada-server

Proposed by Facundo Batista
Status: Rejected
Rejected by: Facundo Batista
Proposed branch: lp:~facundo/magicicada-server/incorporate-client-with-venv
Merge into: lp:magicicada-server
Diff against target: 56 lines (+11/-6)
3 files modified
Makefile (+8/-5)
config-manager.txt (+1/-1)
requirements-devel.txt (+2/-0)
To merge this branch: bzr merge lp:~facundo/magicicada-server/incorporate-client-with-venv
Reviewer Review Type Date Requested Status
chicharreros Pending
Review via email: mp+342650@code.launchpad.net

Commit message

Incorporated the client that uses virtualenv.

To post a comment you must log in.

Unmerged revisions

85. By Facundo Batista

Incorporated the client that uses virtualenv.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile'
--- Makefile 2017-04-22 21:07:36 +0000
+++ Makefile 2018-04-04 14:07:57 +0000
@@ -1,5 +1,5 @@
1# Copyright 2008-2015 Canonical1# Copyright 2008-2015 Canonical
2# Copyright 2015-2016 Chicharreros (https://launchpad.net/~chicharreros)2# Copyright 2015-2018 Chicharreros (https://launchpad.net/~chicharreros)
3#3#
4# This program is free software: you can redistribute it and/or modify4# This program is free software: you can redistribute it and/or modify
5# it under the terms of the GNU Affero General Public License as5# it under the terms of the GNU Affero General Public License as
@@ -107,11 +107,16 @@
107bootstrap:107bootstrap:
108 cat dependencies.txt | sudo xargs apt-get install -y --no-install-recommends108 cat dependencies.txt | sudo xargs apt-get install -y --no-install-recommends
109 cat dependencies-devel.txt | sudo xargs apt-get install -y --no-install-recommends109 cat dependencies-devel.txt | sudo xargs apt-get install -y --no-install-recommends
110 mkdir -p tmp
111
112venv:
113 virtualenv --system-site-packages $(ENV)
114 $(ENV)/bin/pip install -r requirements-devel.txt -r .sourcecode/magicicada-client/requirements.txt
110115
111raw-test:116raw-test:
112 ./test $(TESTFLAGS)117 $(ENV)/bin/python ./test $(TESTFLAGS)
113118
114test: lint sourcedeps clean version start-db start-base start-dbus raw-test stop119test: sourcedeps clean venv lint version start-db start-base start-dbus raw-test stop
115120
116ci-test:121ci-test:
117 $(MAKE) test TESTFLAGS="-1 $(TESTFLAGS)"122 $(MAKE) test TESTFLAGS="-1 $(TESTFLAGS)"
@@ -120,8 +125,6 @@
120 rm -rf tmp/* _trial_temp $(ENV)125 rm -rf tmp/* _trial_temp $(ENV)
121126
122lint:127lint:
123 virtualenv $(ENV)
124 $(ENV)/bin/pip install flake8 rst2html5
125 $(ENV)/bin/flake8 --filename='*.py' --exclude='migrations' $(SRC_DIR)128 $(ENV)/bin/flake8 --filename='*.py' --exclude='migrations' $(SRC_DIR)
126 dev-scripts/check_readme.sh129 dev-scripts/check_readme.sh
127130
128131
=== modified file 'config-manager.txt'
--- config-manager.txt 2018-03-20 19:21:27 +0000
+++ config-manager.txt 2018-04-04 14:07:57 +0000
@@ -25,5 +25,5 @@
25./.sourcecode/dirspec ~ubuntuone-control-tower/dirspec/trunk;revno=1425./.sourcecode/dirspec ~ubuntuone-control-tower/dirspec/trunk;revno=14
26./.sourcecode/django ~ubuntuone-pqm-team/django/stable;revno=1726./.sourcecode/django ~ubuntuone-pqm-team/django/stable;revno=17
27./.sourcecode/u1sync ~facundo/u1sync/opensourcing;revno=1027./.sourcecode/u1sync ~facundo/u1sync/opensourcing;revno=10
28./.sourcecode/magicicada-client ~chicharreros/magicicada-client/trunk;revno=144028./.sourcecode/magicicada-client ~chicharreros/magicicada-client/trunk;revno=1442
29./.sourcecode/magicicada-protocol ~chicharreros/magicicada-protocol/trunk;revno=16929./.sourcecode/magicicada-protocol ~chicharreros/magicicada-protocol/trunk;revno=169
3030
=== added file 'requirements-devel.txt'
--- requirements-devel.txt 1970-01-01 00:00:00 +0000
+++ requirements-devel.txt 2018-04-04 14:07:57 +0000
@@ -0,0 +1,2 @@
1flake8
2rst2html5

Subscribers

People subscribed via source and target branches

to all changes: