Merge lp:~facundo/magicicada-client/fix-travis into lp:magicicada-client

Proposed by Facundo Batista
Status: Merged
Approved by: Natalia Bidart
Approved revision: 1442
Merged at revision: 1442
Proposed branch: lp:~facundo/magicicada-client/fix-travis
Merge into: lp:magicicada-client
Diff against target: 26 lines (+4/-2)
2 files modified
.travis.yml (+1/-1)
Makefile (+3/-1)
To merge this branch: bzr merge lp:~facundo/magicicada-client/fix-travis
Reviewer Review Type Date Requested Status
Natalia Bidart Approve
Review via email: mp+342058@code.launchpad.net

Commit message

- Small Makefile fix for docker rule, in order to fix travis.

Description of the change

Adapt a little Makefile for docker in order to fix travis.

Proof: https://travis-ci.org/chicharreros/magicicada-client/builds/357960309

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.travis.yml'
--- .travis.yml 2018-03-14 21:55:27 +0000
+++ .travis.yml 2018-03-25 11:15:24 +0000
@@ -10,4 +10,4 @@
10 - docker build -t magicicada-client-test-run .10 - docker build -t magicicada-client-test-run .
1111
12script:12script:
13 - docker run magicicada-client-test-run make test13 - docker run magicicada-client-test-run make venv build test
1414
=== modified file 'Makefile'
--- Makefile 2018-03-18 11:59:08 +0000
+++ Makefile 2018-03-25 11:15:24 +0000
@@ -44,9 +44,11 @@
44update-protocol:44update-protocol:
45 cd $(PROTOCOL_DIR) && bzr pull && python setup.py build45 cd $(PROTOCOL_DIR) && bzr pull && python setup.py build
4646
47bootstrap: deps $(PROTOCOL_DIR) $(PROTOCOL_LINK) update-protocol venv47build:
48 $(ENV)/bin/python setup.py build48 $(ENV)/bin/python setup.py build
4949
50bootstrap: deps $(PROTOCOL_DIR) $(PROTOCOL_LINK) update-protocol venv build
51
50docker-bootstrap: clean52docker-bootstrap: clean
51 cat dependencies.txt | xargs apt-get install -y --no-install-recommends53 cat dependencies.txt | xargs apt-get install -y --no-install-recommends
52 cat dependencies-devel.txt | xargs apt-get install -y --no-install-recommends54 cat dependencies-devel.txt | xargs apt-get install -y --no-install-recommends

Subscribers

People subscribed via source and target branches

to all changes: