Merge lp:~evfool/synaptic/lp975578 into lp:synaptic
Proposed by
Robert Roth
Status: | Merged |
---|---|
Merged at revision: | 2105 |
Proposed branch: | lp:~evfool/synaptic/lp975578 |
Merge into: | lp:synaptic |
Diff against target: |
12 lines (+1/-1) 1 file modified
gtk/rgmainwindow.cc (+1/-1) |
To merge this branch: | bzr merge lp:~evfool/synaptic/lp975578 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Hartwig (community) | Needs Fixing | ||
synaptic-developers | Pending | ||
Review via email: mp+133934@code.launchpad.net |
Description of the change
Do not show Successfully marked all available updates status text in case the user cancels the operation on the summary dialog. (LP: #975578)
To post a comment you must log in.
On cancel, the status will be set to:
Failed to mark all available upgrades!
which is not correct.
This should rather not-set/clear the status message, as per cancelling other operations (see gtk/rgmainwindo w.cc:2905, for example), or at least change to mention “cancelled”. Below is a patch for this. Note that the final call to showErrors is a noop on cancel, since askStateChange will discard pending errors if the user cancels.
=== modified file 'gtk/rgmainwind ow.cc' >upgrade( );
--- gtk/rgmainwindow.cc 2012-07-12 20:03:08 +0000
+++ gtk/rgmainwindow.cc 2012-11-13 01:58:53 +0000
@@ -3247,10 +3247,12 @@
else
res = me->_lister-
- me->askStateCha nge(state) ; nge(state) ; >refreshTable( pkg);
+ bool changed = me->askStateCha
me-
- if (res) xt();
me->setStatusTe xt(_("Successfu lly marked available upgrades"));
me->setStatusTe xt(_("Failed to mark all available upgrades!"));
+ if (!changed)
+ me->setStatusTe
+ else if (res)
else