Ubuntu Software Center

Merge lp:~evfool/software-center/lp839389 into lp:software-center

  1. lp839389
  2. Merge into trunk
Proposed by Robert Roth
Status: Merged
Merge reported by: Gary Lasker
Merged at revision: not available
Proposed branch: lp:~evfool/software-center/lp839389
Merge into: lp:software-center
Diff against target: 25 lines (+2/-2)
2 files modified
data/ui/gtk3/report_abuse.ui (+1/-1)
data/ui/gtk3/submit_usefulness.ui (+1/-1)
To merge this branch: bzr merge lp:~evfool/software-center/lp839389
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Review via email: mp+105365@code.launchpad.net

Description of the change

Set icon_name instead of icon for all dialogs, fixing bug #839389.

To post a comment you must log in.
Revision history for this message
Gary Lasker (gary-lasker) wrote :

This displays the correct icon in the *launcher* window, rather than the "not found" icon. Very nice fix, thanks again, Robert!

review: Approve
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Merged into the lp:software-center/5.2 branch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/ui/gtk3/report_abuse.ui'
--- data/ui/gtk3/report_abuse.ui 2011-07-05 09:53:26 +0000
+++ data/ui/gtk3/report_abuse.ui 2012-05-10 17:50:23 +0000
@@ -9,7 +9,7 @@
9 <property name="window_position">center-on-parent</property>9 <property name="window_position">center-on-parent</property>
10 <property name="default_width">400</property>10 <property name="default_width">400</property>
11 <property name="destroy_with_parent">True</property>11 <property name="destroy_with_parent">True</property>
12 <property name="icon">softwarecenter</property>12 <property name="icon_name">softwarecenter</property>
13 <child>13 <child>
14 <object class="GtkVBox" id="dialog-vbox3">14 <object class="GtkVBox" id="dialog-vbox3">
15 <property name="visible">True</property>15 <property name="visible">True</property>
1616
=== modified file 'data/ui/gtk3/submit_usefulness.ui'
--- data/ui/gtk3/submit_usefulness.ui 2011-09-16 09:00:10 +0000
+++ data/ui/gtk3/submit_usefulness.ui 2012-05-10 17:50:23 +0000
@@ -8,7 +8,7 @@
8 <property name="border_width">12</property>8 <property name="border_width">12</property>
9 <property name="window_position">center-on-parent</property>9 <property name="window_position">center-on-parent</property>
10 <property name="destroy_with_parent">True</property>10 <property name="destroy_with_parent">True</property>
11 <property name="icon">softwarecenter</property>11 <property name="icon_name">softwarecenter</property>
12 <child>12 <child>
13 <object class="GtkVBox" id="dialog-vbox3">13 <object class="GtkVBox" id="dialog-vbox3">
14 <property name="visible">True</property>14 <property name="visible">True</property>