Merge lp:~evfool/software-center/fix843766 into lp:software-center

Proposed by Robert Roth
Status: Merged
Merged at revision: 2270
Proposed branch: lp:~evfool/software-center/fix843766
Merge into: lp:software-center
Diff against target: 12 lines (+1/-1)
1 file modified
softwarecenter/ui/gtk3/models/pendingstore.py (+1/-1)
To merge this branch: bzr merge lp:~evfool/software-center/fix843766
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Michael Vogt Pending
Review via email: mp+74396@code.launchpad.net

Description of the change

Fix simple crash caused by using int 0 instead of float 0 to initialize transaction progress in PendingStore. Fixes bug #843766.

To post a comment you must log in.
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Looks great, thank you, Robert!

review: Approve
Revision history for this message
Michael Vogt (mvo) wrote :

Awsome!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'softwarecenter/ui/gtk3/models/pendingstore.py'
--- softwarecenter/ui/gtk3/models/pendingstore.py 2011-07-27 15:53:12 +0000
+++ softwarecenter/ui/gtk3/models/pendingstore.py 2011-09-07 11:30:26 +0000
@@ -81,7 +81,7 @@
81 appname = self.backend.pending_purchases[pkgname].appname81 appname = self.backend.pending_purchases[pkgname].appname
82 status_text = self._render_status_text(82 status_text = self._render_status_text(
83 appname or pkgname, _(u'Installing purchase\u2026'))83 appname or pkgname, _(u'Installing purchase\u2026'))
84 self.append([pkgname, icon, pkgname, status_text, 0, 1, None])84 self.append([pkgname, icon, pkgname, status_text, float(0), 1, None])
8585
86 def _pulse_purchase_helper(self):86 def _pulse_purchase_helper(self):
87 for item in self:87 for item in self: