Merge lp:~etherpulse/podbird/add_description_to_full_view into lp:podbird

Proposed by Eran Uzan
Status: Needs review
Proposed branch: lp:~etherpulse/podbird/add_description_to_full_view
Merge into: lp:podbird
Diff against target: 79 lines (+26/-0)
3 files modified
app/podbird.qml (+3/-0)
app/podcasts.js (+9/-0)
app/ui/FullPlayingView.qml (+14/-0)
To merge this branch: bzr merge lp:~etherpulse/podbird/add_description_to_full_view
Reviewer Review Type Date Requested Status
Michael Sheldon Pending
Review via email: mp+325027@code.launchpad.net

Description of the change

Added description in the full player view.

To post a comment you must log in.

Unmerged revisions

189. By Eran Uzan

Added episode description to the full player view.

188. By Launchpad Translations on behalf of michael-sheldon

Launchpad automatic translations update.

187. By Launchpad Translations on behalf of michael-sheldon

Launchpad automatic translations update.

186. By Launchpad Translations on behalf of michael-sheldon

Launchpad automatic translations update.

185. By Launchpad Translations on behalf of michael-sheldon

Launchpad automatic translations update.

184. By Launchpad Translations on behalf of michael-sheldon

Launchpad automatic translations update.

183. By Launchpad Translations on behalf of michael-sheldon

Launchpad automatic translations update.

182. By Launchpad Translations on behalf of michael-sheldon

Launchpad automatic translations update.

181. By Launchpad Translations on behalf of michael-sheldon

Launchpad automatic translations update.

180. By Launchpad Translations on behalf of michael-sheldon

Launchpad automatic translations update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'app/podbird.qml'
--- app/podbird.qml 2017-01-03 00:02:16 +0000
+++ app/podbird.qml 2017-06-02 21:52:14 +0000
@@ -100,6 +100,7 @@
100 property string currentArtist100 property string currentArtist
101 property string currentImage101 property string currentImage
102 property string currentGuid102 property string currentGuid
103 property string currentDescription
103 property url currentUrl: ""104 property url currentUrl: ""
104105
105 Themes.ThemeManager {106 Themes.ThemeManager {
@@ -261,6 +262,7 @@
261 image: "",262 image: "",
262 guid: "",263 guid: "",
263 position: 0,264 position: 0,
265 description:"",
264 }266 }
265267
266 source = source.toString()268 source = source.toString()
@@ -358,6 +360,7 @@
358 currentImage = meta.image360 currentImage = meta.image
359 currentGuid = meta.guid361 currentGuid = meta.guid
360 player.pendingSeek = meta.position362 player.pendingSeek = meta.position
363 currentDescription = meta.description
361 }364 }
362 }365 }
363366
364367
=== modified file 'app/podcasts.js'
--- app/podcasts.js 2017-01-03 00:02:16 +0000
+++ app/podcasts.js 2017-06-02 21:52:14 +0000
@@ -114,6 +114,7 @@
114 image: "",114 image: "",
115 guid: "",115 guid: "",
116 position: 0,116 position: 0,
117 description:"",
117 }118 }
118119
119 db.transaction(function(tx) {120 db.transaction(function(tx) {
@@ -125,6 +126,14 @@
125 meta.image = episode.image126 meta.image = episode.image
126 meta.guid = episode.guid127 meta.guid = episode.guid
127 meta.position = episode.position128 meta.position = episode.position
129
130 if(meta.guid != "") {
131 var rs2 = tx.executeSql("SELECT * FROM Episode WHERE guid = ?", [meta.guid]);
132 if (rs2.rows.length > 0) {
133 var episodeData = rs2.rows.item(0);
134 meta.description = episodeData.description
135 }
136 }
128 }137 }
129 });138 });
130139
131140
=== modified file 'app/ui/FullPlayingView.qml'
--- app/ui/FullPlayingView.qml 2017-01-01 14:28:51 +0000
+++ app/ui/FullPlayingView.qml 2017-06-02 21:52:14 +0000
@@ -117,6 +117,20 @@
117 textSize: Label.Small117 textSize: Label.Small
118 color: podbird.appTheme.baseSubText118 color: podbird.appTheme.baseSubText
119 }119 }
120 Text {
121 id: description
122 anchors.left: parent.left
123 anchors.right: parent.right
124 anchors.top: artist.bottom
125 anchors.topMargin: units.gu(2)
126 anchors.bottomMargin: units.gu(2)
127 anchors.bottom: scrubber.top
128 text: currentDescription
129 elide: Text.ElideRight
130 wrapMode: Text.WordWrap
131 color: podbird.appTheme.baseSubText
132 visible: currentDescription != ""
133 }
120 134
121 Slider {135 Slider {
122 id: scrubber136 id: scrubber

Subscribers

People subscribed via source and target branches

to status/vote changes: