Merge lp:~er-abhinav-upadhyay/ubuntu/natty/tomcat6/bug707405 into lp:ubuntu/natty/tomcat6
Proposed by
Abhinav Upadhyay
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 33 | ||||
Proposed branch: | lp:~er-abhinav-upadhyay/ubuntu/natty/tomcat6/bug707405 | ||||
Merge into: | lp:ubuntu/natty/tomcat6 | ||||
Diff against target: |
43 lines (+20/-2) 2 files modified
debian/changelog (+7/-0) debian/tomcat6-instance-create (+13/-2) |
||||
To merge this branch: | bzr merge lp:~er-abhinav-upadhyay/ubuntu/natty/tomcat6/bug707405 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Dave Walker (community) | Approve | ||
Barry Warsaw (community) | Needs Fixing | ||
Clint Byrum | Pending | ||
Ubuntu branches | Pending | ||
Review via email: mp+52379@code.launchpad.net |
Commit message
tomcat6-
as per http://
Description of the change
As per the bug #707405, tomcat6-
I have modified the tomcat6-
To post a comment you must log in.
As an alternative one could use this for number detection:
if ! echo $port | grep -Eq '^\-?[0-9]*$' ; then
Advantages:
* more obvious match of exact *type* of number expected (integers only with optional leading minus)
* no redirect of errors to /dev/null (in case something else goes wrong not involving the failure you're trying to trigger)