Merge lp:~elachuni/software-center/any-language into lp:software-center
Proposed by
Anthony Lenton
Status: | Merged |
---|---|
Merged at revision: | 2664 |
Proposed branch: | lp:~elachuni/software-center/any-language |
Merge into: | lp:software-center |
Diff against target: |
189 lines (+93/-30) 2 files modified
softwarecenter/ui/gtk3/widgets/reviews.py (+25/-19) test/gtk3/test_widgets.py (+68/-11) |
To merge this branch: | bzr merge lp:~elachuni/software-center/any-language |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Vogt | Approve | ||
Review via email: mp+88877@code.launchpad.net |
Description of the change
Overview
========
This branch adds an 'Any language' option to the review language dropdown
Details
=======
At the same time I removed the "Show reviews in English" button as it becomes redundant as users can select to display reviews in any language.
The big plan is that, once users can choose to display reviews in any language, and we always fall back to fetch reviews for older versions, the number of reported ratings and visible reviews will match.
Some tests were added for the review list widget, so I split that out into its own test case.
To post a comment you must log in.
Thanks! This looks very good, especially the tests are done in a nice and elegant way. Quite impressive.
While working at this code it would be great to extend the combobox to have not only "en" but a proper xml/iso- codes/iso_ 639_3.xml short ids to language names (including translations "iso_639_ 3", language_name).
mapping from /usr/share/
via dgettext(
But that is of course not relevant to the MP at hand which looks great.