Merge lp:~dubstar-04/ubuntu-ui-toolkit/MainViewMouseFocus into lp:ubuntu-ui-toolkit/staging
Status: | Rejected |
---|---|
Rejected by: | Cris Dywan |
Proposed branch: | lp:~dubstar-04/ubuntu-ui-toolkit/MainViewMouseFocus |
Merge into: | lp:ubuntu-ui-toolkit/staging |
Diff against target: |
12 lines (+1/-1) 1 file modified
src/Ubuntu/PerformanceMetrics/PerformanceOverlay.qml (+1/-1) |
To merge this branch: | bzr merge lp:~dubstar-04/ubuntu-ui-toolkit/MainViewMouseFocus |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zsombor Egri | Needs Information | ||
Review via email: mp+299861@code.launchpad.net |
Description of the change
Changed the MouseArea{} enabled: property to visible:
This still stops the mouse cursor changing when the performance overlay is enabled but the mouse cursor behaves as intended when the performance overlay isn't active.
To Test:
1. Compile UITK and test the code sample from the bug report. The mouse should behave as intended and the cursor should be displayed as a cross.
2. Set the performance overlay to be active "export PERFORMANCE_
3. Disable the overlay "export PERFORMANCE_
Unmerged revisions
- 2033. By Dubstar_04
-
Only make the MouseArea visible when its needed.
- 2032. By Dubstar_04
-
Stop the PerformanceOverlay Stealing the mouse focus.
This feels a bit weird to me, that the MouseArea steals the cursor. I've tested an MR of mine (SplitView in subject) where I had the topmost component a Window, in which there was an active MouseArea, and that did not steal the resize cursor from the SplitView's resize handlers... I feel we need to dig more on this...