Merge lp:~donadigo/appcenter/fix-1609292-update-cache-ui into lp:~elementary-apps/appcenter/appcenter

[Adam Bieńkowski]

* Update count badge on launch.

Fixes bug #1609292: "Notification for AppCenter indicates new packages though there are none".

This branch fixes that the UpdateView updates and shows no updates while the count badge is still there not updating how many updates there are remaining.

[Jeremy Wootten (jeremywootten)]

Approved (code - function not tested)

review: Approve (code)

=== modified file 'src/Application.vala'
--- src/Application.vala	2016-06-19 21:09:16 +0000
+++ src/Application.vala	2016-08-09 13:00:13 +0000
@@ -57,13 +57,15 @@
 
     public override void activate () {
         if (silent) {
+            AppCenterCore.Client.get_default ().update_cache.begin ();
             silent = false;
-            AppCenterCore.Client.get_default ();
             hold ();
             return;
         }
 
         if (main_window == null) {
+            AppCenterCore.Client.get_default ().update_cache.begin (true);
+
             main_window = new MainWindow (this);
             main_window.destroy.connect (() => {
                 main_window = null;
 
=== modified file 'src/Core/Client.vala'
--- src/Core/Client.vala	2016-07-18 17:20:11 +0000
+++ src/Core/Client.vala	2016-08-09 13:00:13 +0000
@@ -40,8 +40,6 @@
         } catch (Error e) {
             error (e.message);
         }
-
-        update_cache.begin ();
     }
 
     construct {
@@ -338,7 +336,6 @@
         return package;
     }
 
-
     public async void refresh_updates () {
         var update_task = new AppCenter.Task ();
         try {
@@ -387,9 +384,9 @@
         return size;
     }
 
-    public async void update_cache () {
+    public async void update_cache (bool force = false) {
         // One cache update a day, keeps the doctor away!
-        if (last_cache_update == null || (new DateTime.now_local ()).difference (last_cache_update) >= GLib.TimeSpan.DAY) {
+        if (force || last_cache_update == null || (new DateTime.now_local ()).difference (last_cache_update) >= GLib.TimeSpan.DAY) {
             var refresh_task = new AppCenter.Task ();
             try {
                 yield refresh_task.refresh_cache_async (false, null, (t, p) => { });