Merge lp:~dobey/ubuntu-sso-client/new-kr-props into lp:ubuntu-sso-client
Proposed by
dobey
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | dobey | ||||
Approved revision: | 726 | ||||
Merged at revision: | 723 | ||||
Proposed branch: | lp:~dobey/ubuntu-sso-client/new-kr-props | ||||
Merge into: | lp:ubuntu-sso-client | ||||
Diff against target: |
220 lines (+79/-23) 2 files modified
ubuntu_sso/utils/tests/test_txsecrets.py (+27/-5) ubuntu_sso/utils/txsecrets.py (+52/-18) |
||||
To merge this branch: | bzr merge lp:~dobey/ubuntu-sso-client/new-kr-props | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alejandro J. Cura (community) | Approve | ||
Natalia Bidart (community) | Approve | ||
Review via email: mp+65419@code.launchpad.net |
Commit message
Use the new property names for fdo secrets API
Description of the change
This seems to work on both versions of gnome-keyring (2.3x in 11.04, and 3.x in 11.10).
To post a comment you must log in.
The code looks good, but when running this branch and having the control panel using it, I got the error below when trying to remove the current device:
2011-06-21 19:52:26, 337:337. 815999985 - ubuntu_sso.main - ERROR - CredentialsMana gement: emitting CredentialsError with app_name "Ubuntu One" and error_dict {'errtype': 'DBusException', 'message': dbus.String( u'Invalid properties')}.
Same error when trying to store credentials in the keyring:
2011-06-21 19:56:07, 373:373. 473882675 - ubuntu_sso.main - DEBUG - SSOLogin: emitting LoginError with app_name "Ubuntu One" and error {'errtype': 'DBusException', 'message': dbus.String( u'Invalid properties')}
This test was made on a Natty (updated today) machine.