Merge lp:~divmod-dev/divmod.org/829866-explicit-close into lp:divmod.org

Proposed by Tristan Seligmann
Status: Merged
Approved by: Jonathan Jacobs
Approved revision: 2682
Merged at revision: 2679
Proposed branch: lp:~divmod-dev/divmod.org/829866-explicit-close
Merge into: lp:divmod.org
Prerequisite: lp:~divmod-dev/divmod.org/829865-PYTHONPATH-handling
Diff against target: 33 lines (+3/-2)
2 files modified
Axiom/axiom/test/test_batch.py (+1/-0)
Axiom/axiom/test/test_files.py (+2/-2)
To merge this branch: bzr merge lp:~divmod-dev/divmod.org/829866-explicit-close
Reviewer Review Type Date Requested Status
Jonathan Jacobs Approve
Review via email: mp+72275@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jonathan Jacobs (jjacobs) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Axiom/axiom/test/test_batch.py'
--- Axiom/axiom/test/test_batch.py 2009-07-07 20:35:43 +0000
+++ Axiom/axiom/test/test_batch.py 2011-08-20 01:56:18 +0000
@@ -562,6 +562,7 @@
562 ss = substore.SubStore.createNew(s, 'substore')562 ss = substore.SubStore.createNew(s, 'substore')
563 service.IService(s).startService()563 service.IService(s).startService()
564 d = iaxiom.IBatchService(ss).call(BatchCallTestItem(store=ss.open()).callIt)564 d = iaxiom.IBatchService(ss).call(BatchCallTestItem(store=ss.open()).callIt)
565 ss.close()
565 def called(ign):566 def called(ign):
566 self.failUnless(ss.open().findUnique(BatchCallTestItem).called, "Was not called")567 self.failUnless(ss.open().findUnique(BatchCallTestItem).called, "Was not called")
567 return service.IService(s).stopService()568 return service.IService(s).stopService()
568569
=== modified file 'Axiom/axiom/test/test_files.py'
--- Axiom/axiom/test/test_files.py 2008-05-06 13:33:30 +0000
+++ Axiom/axiom/test/test_files.py 2011-08-20 01:56:18 +0000
@@ -73,7 +73,7 @@
73 TEST_STR = "test 123"73 TEST_STR = "test 123"
7474
75 def cb(fpath):75 def cb(fpath):
76 fpath.open("w").write(TEST_STR)76 fpath.setContent(TEST_STR)
7777
78 PathTesterItem(store=s,78 PathTesterItem(store=s,
79 relpath=fpath)79 relpath=fpath)
@@ -83,7 +83,7 @@
83 s2 = Store(npath)83 s2 = Store(npath)
84 pti = list(s2.query(PathTesterItem))[0]84 pti = list(s2.query(PathTesterItem))[0]
8585
86 self.assertEquals(pti.relpath.open().read(),86 self.assertEquals(pti.relpath.getContent(),
87 TEST_STR)87 TEST_STR)
8888
89 return rel.close().addCallback(cb)89 return rel.close().addCallback(cb)

Subscribers

People subscribed via source and target branches

to all changes: