Merge lp:~death-7/wicd/wicd into lp:wicd/1.6
Proposed by
Deathzor
Status: | Rejected |
---|---|
Rejected by: | Pieter Leclerc |
Proposed branch: | lp:~death-7/wicd/wicd |
Merge into: | lp:wicd/1.6 |
Diff against target: |
32 lines (+12/-3) 1 file modified
wicd/wnettools.py (+12/-3) |
To merge this branch: | bzr merge lp:~death-7/wicd/wicd |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Pieter Leclerc (community) | Needs Fixing | ||
Review via email: mp+225865@code.launchpad.net |
Description of the change
Minor bug fix ( affecting gentoo dhclient users )
To post a comment you must log in.
I added some inline notes about what, in my opinion, needs fixing.
I'm a bit skeptical about the "hacky" nature of the changes, so it would be great if you could elaborate on that a bit, about why dhclient reads from STDIN on Gentoo... I am using it as well and I don't notice any problems, so why is Gentoo's dhclient different?
Please improve, thanks a lot in advance, and we'll merge it!