Merge lp:~davidmhewitt/slingshot/fix-1665931 into lp:~elementary-pantheon/slingshot/trunk

Proposed by David Hewitt
Status: Merged
Approved by: Danielle Foré
Approved revision: 744
Merged at revision: 744
Proposed branch: lp:~davidmhewitt/slingshot/fix-1665931
Merge into: lp:~elementary-pantheon/slingshot/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
src/Widgets/SearchView.vala (+1/-1)
To merge this branch: bzr merge lp:~davidmhewitt/slingshot/fix-1665931
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Review via email: mp+317713@code.launchpad.net

Commit message

Move link search results into the internet category.

Description of the change

Two separate headings for links and other actions were previously created because a label is created for each result type, actions are considered one type and links another. Both were set to have the label "Actions". This branch sorts links under an "Internet" heading.

It becomes very difficult to group links in with the actions without changing their priority and bringing them much further up the search results. Proposing this as a temporary fix until the code can be re-written to enable better groupings and sorting based upon search relevance as well as group priority.

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

Works for me

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Widgets/SearchView.vala'
--- src/Widgets/SearchView.vala 2017-02-18 21:09:29 +0000
+++ src/Widgets/SearchView.vala 2017-02-19 00:43:31 +0000
@@ -133,7 +133,7 @@
133 result_type = SearchItem.ResultType.INTERNET;133 result_type = SearchItem.ResultType.INTERNET;
134 }134 }
135 } else if (match is Synapse.LinkPlugin.Result) {135 } else if (match is Synapse.LinkPlugin.Result) {
136 result_type = SearchItem.ResultType.LINK;136 result_type = SearchItem.ResultType.INTERNET;
137 }137 }
138138
139 if (result_type == SearchItem.ResultType.UNKNOWN) {139 if (result_type == SearchItem.ResultType.UNKNOWN) {

Subscribers

People subscribed via source and target branches