Merge lp:~davidc3/unity-scope-reddit/new-ssl-uri into lp:unity-scope-reddit

[David Callé]

New API uri

New API uri

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:5
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~davidc3/unity-scope-reddit/new-ssl-uri/+merge/217342/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-armhf-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-i386-ci/9

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-reddit-ci/9/rebuild

review: Needs Fixing (continuous-integration)

[Chris Wayne (cwayne)]

LGTM

review: Approve

[David Callé (davidc3)]

Thanks Chris, but before merging, I'm reaching to Reddit to get a definitive answer on their ssl API, this one appears to be redirecting to http anyway.

review: Needs Information

[Olli Ries (ories)]

what about the cert check, suggested by Marc? Ben's comments in the bug also seem to indicate that simply changing the URL won't fix it.

[lp:~davidc3/unity-scope-reddit/new-ssl-uri]

6. By David Callé on 2014-05-02

Last week of research shows that no proper ssl reddit uri exists today for non-authenticated API calls. Switching to http for the server->reddit talk, user to server is -as always- https

[Simon Davy (bloodearnest)]

review: Approve

[Simon Davy (bloodearnest)]

> what about the cert check, suggested by Marc? Ben's comments in the bug also
> seem to indicate that simply changing the URL won't fix it.

It will provide unauthenticated encryption, which is better than no encryption. Only prevents casual eavesdropping, not MITM, but that fix is bit more involved.

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:6
http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-ci/10/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-armhf-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-i386-ci/10

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-reddit-ci/10/rebuild

review: Approve (continuous-integration)

[David Callé (davidc3)]

review: Approve

=== modified file 'src/unity_reddit_daemon.py'
--- src/unity_reddit_daemon.py	2013-09-24 22:21:01 +0000
+++ src/unity_reddit_daemon.py	2014-05-02 10:15:40 +0000
@@ -30,7 +30,7 @@
 
 GROUP_NAME = 'com.canonical.Unity.Scope.Info.Reddit'
 UNIQUE_PATH = '/com/canonical/unity/scope/info/reddit'
-SEARCH_URI = 'https://reddit.com/'
+SEARCH_URI = 'http://reddit.com/'
 SEARCH_HINT = _('Search Reddit')
 NO_RESULTS_HINT = _('Sorry, there are no subreddits that match your search.')
 PROVIDER_CREDITS = _('Powered by Reddit')