Unity API

Merge lp:~dandrader/unity-api/surfaceAllowClientResize into lp:unity-api

  1. surfaceAllowClientResize
  2. Merge into trunk
Proposed by Daniel d'Andrada
Status: Merged
Approved by: Gerry Boland
Approved revision: 277
Merged at revision: 279
Proposed branch: lp:~dandrader/unity-api/surfaceAllowClientResize
Merge into: lp:unity-api
Prerequisite: lp:~mzanetti/unity-api/private-quicklist-entries
Diff against target: 65 lines (+16/-2)
3 files modified
debian/changelog (+4/-1)
include/unity/shell/application/CMakeLists.txt (+1/-1)
include/unity/shell/application/MirSurfaceInterface.h (+11/-0)
To merge this branch: bzr merge lp:~dandrader/unity-api/surfaceAllowClientResize
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Approve
Gerry Boland (community) Approve
Review via email: mp+319730@code.launchpad.net

This proposal supersedes a proposal from 2017-03-07.

Commit message

MirSurfaceInterface::allowClientResize - specify if client can resize its windows

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:276
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/149/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4343
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4371
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4205
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4205/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4205
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4205/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4205
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4205/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4205
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4205/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4205
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4205/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4205
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4205/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/149/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Gerry Boland (gerboland) wrote :

Ok.

review: Approve
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:277
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/151/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4422
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4450
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4283
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4283/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4283
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4283/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4283
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4283/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4283
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4283/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4283
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4283/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4283
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4283/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/151/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2017-03-13 17:57:02 +0000
+++ debian/changelog 2017-03-13 17:57:03 +0000
@@ -1,8 +1,11 @@
1unity-api (8.5) zesty; urgency=medium1unity-api (8.5) UNRELEASED; urgency=medium
22
3 [ Michael Zanetti ]3 [ Michael Zanetti ]
4 * Add RoleIsPrivate to launcher's quicklist entries4 * Add RoleIsPrivate to launcher's quicklist entries
55
6 [ Daniel d'Andrada ]
7 * MirSurfaceInterface::allowClientResize
8
6 -- Michael Zanetti <michael.zanetti@canonical.com> Fri, 24 Feb 2017 13:57:12 +00009 -- Michael Zanetti <michael.zanetti@canonical.com> Fri, 24 Feb 2017 13:57:12 +0000
710
8unity-api (8.4+17.04.20170223-0ubuntu1) zesty; urgency=medium11unity-api (8.4+17.04.20170223-0ubuntu1) zesty; urgency=medium
912
=== modified file 'include/unity/shell/application/CMakeLists.txt'
--- include/unity/shell/application/CMakeLists.txt 2017-01-26 11:07:35 +0000
+++ include/unity/shell/application/CMakeLists.txt 2017-03-13 17:57:03 +0000
@@ -7,7 +7,7 @@
77
8set(UNITY_API_LIB_HDRS ${UNITY_API_LIB_HDRS} ${headers} ${internal_headers} PARENT_SCOPE)8set(UNITY_API_LIB_HDRS ${UNITY_API_LIB_HDRS} ${headers} ${internal_headers} PARENT_SCOPE)
99
10set(VERSION 26)10set(VERSION 27)
11set(PKGCONFIG_NAME "unity-shell-application")11set(PKGCONFIG_NAME "unity-shell-application")
12set(PKGCONFIG_DESCRIPTION "Unity shell Application APIs")12set(PKGCONFIG_DESCRIPTION "Unity shell Application APIs")
13set(PKGCONFIG_REQUIRES "Qt5Core")13set(PKGCONFIG_REQUIRES "Qt5Core")
1414
=== modified file 'include/unity/shell/application/MirSurfaceInterface.h'
--- include/unity/shell/application/MirSurfaceInterface.h 2017-01-26 11:07:35 +0000
+++ include/unity/shell/application/MirSurfaceInterface.h 2017-03-13 17:57:03 +0000
@@ -165,6 +165,13 @@
165 Q_PROPERTY(bool confinesMousePointer READ confinesMousePointer NOTIFY confinesMousePointerChanged)165 Q_PROPERTY(bool confinesMousePointer READ confinesMousePointer NOTIFY confinesMousePointerChanged)
166166
167 /**167 /**
168 * @brief Whether to comply to resize requests coming from the client side
169 *
170 * It's true by default
171 */
172 Q_PROPERTY(bool allowClientResize READ allowClientResize WRITE setAllowClientResize NOTIFY allowClientResizeChanged)
173
174 /**
168 * @brief The parent MirSurface or null if this is a top-level surface175 * @brief The parent MirSurface or null if this is a top-level surface
169 */176 */
170 Q_PROPERTY(MirSurfaceInterface* parentSurface READ parentSurface CONSTANT)177 Q_PROPERTY(MirSurfaceInterface* parentSurface READ parentSurface CONSTANT)
@@ -221,6 +228,9 @@
221228
222 virtual bool confinesMousePointer() const = 0;229 virtual bool confinesMousePointer() const = 0;
223230
231 virtual bool allowClientResize() const = 0;
232 virtual void setAllowClientResize(bool) = 0;
233
224 virtual QPoint requestedPosition() const = 0;234 virtual QPoint requestedPosition() const = 0;
225 virtual void setRequestedPosition(const QPoint &) = 0;235 virtual void setRequestedPosition(const QPoint &) = 0;
226236
@@ -270,6 +280,7 @@
270 void focusedChanged(bool value);280 void focusedChanged(bool value);
271 void inputBoundsChanged(QRect value);281 void inputBoundsChanged(QRect value);
272 void confinesMousePointerChanged(bool value);282 void confinesMousePointerChanged(bool value);
283 void allowClientResizeChanged(bool value);
273 /// @endcond284 /// @endcond
274285
275 /**286 /**

Subscribers

People subscribed via source and target branches

to all changes: