Merge lp:~cprov/adt-cloud-worker/selftest into lp:adt-cloud-worker

[Celso Providelo]

Adding basic DEP-8 tests for uci-nova, it's mainly intended to ensure feature consistency of uci-nova accross clouds.

Adding basic DEP-8 tests for uci-nova, it's mainly intended to ensure feature consistency of uci-nova accross clouds.

[Paul Larson (pwlars)]

Looks good as is. I had a few minor suggestions, but mostly just personal preference.

review: Approve

[Joe Talbott (joetalbott)]

This looks good to me as well. I agree with Paul's suggestions as well but don't see them as blocking.

review: Approve

[Celso Providelo (cprov)]

Paul, Joe,

Thanks for the review.

I've updated the README as suggested and proposed a new change for the test_proxy checks, actually check access we depend on in production. Since they are only 3 and tend to be gone once the sources get fixed, we can make the test reflect the exact conditions we expect in production, i.e. when the test fails we know what will be broken and can act accordingly.

[lp:~cprov/adt-cloud-worker/selftest]

43. By Celso Providelo on 2015-04-29

Extending dogfood proxy tests to reflect the exact access we depend on in production.

[Thomi Richards (thomir-deactivatedaccount)]

Please don't add more shell code that we need to maintain.

I agree that a selftest suite is a great thing to have, but I think writing it as a bash script is a bad idea. This could be trivially written as a python test suite, and would be easier to extend and maintain over time.

review: Needs Fixing

[lp:~cprov/adt-cloud-worker/selftest]

44. By Celso Providelo on 2015-04-29

Re-write the basic test suite in python ... because *simple* is not enough.

[Thomi Richards (thomir-deactivatedaccount)]

I think you could have gotten away without making dep8/tests/__init__.py - but there's nothing wrong with it either.

Thanks for the python rewrite.

review: Approve

[Celso Providelo (cprov)]

THomi,

Fine, python it is ... However, it carries a lot more test dependencies and specialties (allow-stderr) that were not a problem with the much simpler, main-stream and perfectly functional shell test suite.

This tendency of aiming for *bonus* points and twinkling stars, instead of getting things done on time, is what makes us kind of borderline mediocre ... We haven't reached the point where people start criticising our design choices and coding skills, simply because we have nothing to show :-/ I'd rather live with bad ideas that work than keep chasing tangential satisfaction on "perfect solutions" that do not serve their purpose.

That all said, enough ranting. Let's land the tests and use it to our benefit for validating other aspects of uci-nova.

=== modified file 'README.rst'
--- README.rst	2015-04-28 03:13:30 +0000
+++ README.rst	2015-04-29 04:44:51 +0000
@@ -58,6 +58,7 @@
 
   $ python setup.py test
 
+
 Run the Service
 ===============
 
@@ -90,3 +91,24 @@
 
 It's possible to run multiple instances of the worker in the same machine
 by providing diffent working directories of configuration file path.
+
+
+Run DEP-8 tests for uci-nova ssh-setup
+======================================
+
+`uci-nova` is a special `adt-run` ssh-setup for adjusting testbed for a
+production like environment.
+
+We have created a specific test-suite for ensuring it works as expected on
+any choice of cloud.
+
+The `uci-nova` tests can be run from this project as::
+
+  adt-run --built-tree ./dep8 -d \
+      --- ssh -s ./uci-nova -d \
+      -- -d --flavor m1.small \
+         --image=ubuntu-trusty-14.04-amd64-server-20150417-disk1.img \
+         --net-id=415a0839-eb05-4e7a-907c-413c657f4bf5
+
+(adjust cloud-specific options like --flavor, --image and --net-id according
+to the available environment)
 
=== added directory 'dep8'
=== added directory 'dep8/debian'
=== added directory 'dep8/debian/tests'
=== added file 'dep8/debian/tests/control'
--- dep8/debian/tests/control	1970-01-01 00:00:00 +0000
+++ dep8/debian/tests/control	2015-04-29 04:44:51 +0000
@@ -0,0 +1,3 @@
+Test-Command: python3 -m unittest tests
+Restrictions: allow-stderr
+Depends: python3, python3-requests
 
=== added directory 'dep8/tests'
=== added file 'dep8/tests/__init__.py'
--- dep8/tests/__init__.py	1970-01-01 00:00:00 +0000
+++ dep8/tests/__init__.py	2015-04-29 04:44:51 +0000
@@ -0,0 +1,17 @@
+# Copyright (C) 2015 Canonical
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+from tests.test_proxy import *
 
=== added file 'dep8/tests/test_proxy.py'
--- dep8/tests/test_proxy.py	1970-01-01 00:00:00 +0000
+++ dep8/tests/test_proxy.py	2015-04-29 04:44:51 +0000
@@ -0,0 +1,48 @@
+#!/usr/bin/env python3
+#
+# Copyright (C) 2015 Canonical
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+"""Tests for 'uci-nova' testbed proxy setup."""
+
+import requests
+import unittest
+
+
+class TestUciNova(unittest.TestCase):
+
+    def assertAccess(self, url):
+        """Assert given url is accessible (HTTP 200)."""
+        r = requests.get(url, headers={'Connection': 'close'})
+        self.assertEqual(requests.codes.ok, r.status_code)
+
+    def test_unity_firefox_extension(self):
+        # 'unity-firefox-extension' test requires pypi for installing mozmill.
+        self.assertAccess('https://pypi.python.org/pypi')
+
+    def test_lxc(self):
+        # 'lxc' test requires keyserver access.
+        self.assertAccess('http://keyserver.ubuntu.com')
+
+    def test_linux(self):
+        # 'linux' test requires access to kernel.ubuntu.com and a specific
+        # github project (patch).
+        self.assertAccess('http://kernel.ubuntu.com')
+        self.assertAccess('https://github.com/redpig/seccomp')
+
+
+if __name__ == '__main__':
+    unittest.main()