Merge lp:~costales/anoise/man-middle into lp:anoise

Proposed by costales
Status: Merged
Approved by: costales
Approved revision: 56
Merged at revision: 54
Proposed branch: lp:~costales/anoise/man-middle
Merge into: lp:anoise
Diff against target: 128 lines (+10/-26)
7 files modified
anoise/anoise.py (+1/-1)
anoise/preferences.py (+3/-3)
anoise/preferences.ui (+1/-17)
anoise/utils.py (+1/-1)
debian/changelog (+1/-1)
debian/control (+1/-1)
setup.py (+2/-2)
To merge this branch: bzr merge lp:~costales/anoise/man-middle
Reviewer Review Type Date Requested Status
costales Pending
Review via email: mp+325684@code.launchpad.net

Description of the change

Migrated os.system to subprocess

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'anoise/anoise.py'
--- anoise/anoise.py 2017-06-12 20:36:07 +0000
+++ anoise/anoise.py 2017-06-14 18:26:29 +0000
@@ -1,5 +1,5 @@
1# -*- coding: utf-8 -*-1# -*- coding: utf-8 -*-
2# ANoise 0.0.27 (Ambient Noise)2# ANoise 0.0.28 (Ambient Noise)
3# Copyright (C) 2015 Marcos Alvarez Costales https://launchpad.net/~costales3# Copyright (C) 2015 Marcos Alvarez Costales https://launchpad.net/~costales
4#4#
5# ANoise is free software; you can redistribute it and/or modify5# ANoise is free software; you can redistribute it and/or modify
66
=== modified file 'anoise/preferences.py'
--- anoise/preferences.py 2017-06-12 20:36:07 +0000
+++ anoise/preferences.py 2017-06-14 18:26:29 +0000
@@ -1,5 +1,5 @@
1# -*- coding: utf-8 -*-1# -*- coding: utf-8 -*-
2# ANoise 0.0.27 (Ambient Noise)2# ANoise 0.0.28 (Ambient Noise)
3# Copyright (C) 2015 Marcos Alvarez Costales https://launchpad.net/~costales3# Copyright (C) 2015 Marcos Alvarez Costales https://launchpad.net/~costales
4#4#
5# ANoise is free software; you can redistribute it and/or modify5# ANoise is free software; you can redistribute it and/or modify
@@ -16,7 +16,7 @@
16# along with ANoise; if not, see http://www.gnu.org/licenses16# along with ANoise; if not, see http://www.gnu.org/licenses
17# for more information.17# for more information.
1818
19import gi, os, shutil, webbrowser19import gi, os, shutil, webbrowser, subprocess
20from datetime import datetime, timedelta20from datetime import datetime, timedelta
21gi.require_version('Gtk', '3.0')21gi.require_version('Gtk', '3.0')
22gi.require_version('WebKit', '3.0')22gi.require_version('WebKit', '3.0')
@@ -118,7 +118,7 @@
118 def _on_navigation_requested(self, view, frame, req):118 def _on_navigation_requested(self, view, frame, req):
119 uri = req.get_uri()119 uri = req.get_uri()
120 if uri and uri.startswith('apt'): # OS installer120 if uri and uri.startswith('apt'): # OS installer
121 os.system('apturl %s &' % uri)121 subprocess.Popen(["apturl", uri], shell=False)
122 if uri and uri.startswith('http'): # authors122 if uri and uri.startswith('http'): # authors
123 webbrowser.open(uri)123 webbrowser.open(uri)
124 return True124 return True
125125
=== modified file 'anoise/preferences.ui'
--- anoise/preferences.ui 2015-04-27 17:32:53 +0000
+++ anoise/preferences.ui 2017-06-14 18:26:29 +0000
@@ -1,5 +1,5 @@
1<?xml version="1.0" encoding="UTF-8"?>1<?xml version="1.0" encoding="UTF-8"?>
2<!-- Generated with glade 3.16.1 -->2<!-- Generated with glade 3.18.3 -->
3<interface domain="anoise">3<interface domain="anoise">
4 <requires lib="gtk+" version="3.4"/>4 <requires lib="gtk+" version="3.4"/>
5 <object class="GtkAdjustment" id="adjustment_timer">5 <object class="GtkAdjustment" id="adjustment_timer">
@@ -238,22 +238,6 @@
238 <property name="can_focus">False</property>238 <property name="can_focus">False</property>
239 <property name="margin_top">18</property>239 <property name="margin_top">18</property>
240 <child>240 <child>
241 <object class="GtkLinkButton" id="url_donate">
242 <property name="label" translatable="yes">Donate?</property>
243 <property name="visible">True</property>
244 <property name="can_focus">True</property>
245 <property name="receives_default">True</property>
246 <property name="tooltip_text" translatable="yes">Thanks in advance!</property>
247 <property name="relief">none</property>
248 <property name="uri">http://gufw.org/donate_anoise</property>
249 </object>
250 <packing>
251 <property name="expand">False</property>
252 <property name="fill">False</property>
253 <property name="position">0</property>
254 </packing>
255 </child>
256 <child>
257 <object class="GtkAspectFrame" id="aspectframe1">241 <object class="GtkAspectFrame" id="aspectframe1">
258 <property name="visible">True</property>242 <property name="visible">True</property>
259 <property name="can_focus">False</property>243 <property name="can_focus">False</property>
260244
=== modified file 'anoise/utils.py'
--- anoise/utils.py 2017-06-12 20:36:07 +0000
+++ anoise/utils.py 2017-06-14 18:26:29 +0000
@@ -1,5 +1,5 @@
1# -*- coding: utf-8 -*-1# -*- coding: utf-8 -*-
2# ANoise 0.0.27 (Ambient Noise)2# ANoise 0.0.28 (Ambient Noise)
3# Copyright (C) 2015 Marcos Alvarez Costales https://launchpad.net/~costales3# Copyright (C) 2015 Marcos Alvarez Costales https://launchpad.net/~costales
4#4#
5# ANoise is free software; you can redistribute it and/or modify5# ANoise is free software; you can redistribute it and/or modify
66
=== modified file 'debian/changelog'
--- debian/changelog 2017-06-12 20:51:03 +0000
+++ debian/changelog 2017-06-14 18:26:29 +0000
@@ -1,4 +1,4 @@
1anoise (0.0.27) xenial; urgency=low1anoise (0.0.28) xenial; urgency=low
22
3 * Fixed sound menu control3 * Fixed sound menu control
44
55
=== modified file 'debian/control'
--- debian/control 2017-06-12 20:36:07 +0000
+++ debian/control 2017-06-14 18:26:29 +0000
@@ -1,7 +1,7 @@
1Source: anoise1Source: anoise
2Section: sound2Section: sound
3Priority: extra3Priority: extra
4Standards-Version: 0.0.274Standards-Version: 0.0.28
5Maintainer: costales <costales.marcos@gmail.com>5Maintainer: costales <costales.marcos@gmail.com>
6Build-Depends: python-distutils-extra, debhelper (>=7)6Build-Depends: python-distutils-extra, debhelper (>=7)
7Homepage: https://code.launchpad.net/anoise7Homepage: https://code.launchpad.net/anoise
88
=== modified file 'setup.py'
--- setup.py 2017-06-12 20:36:07 +0000
+++ setup.py 2017-06-14 18:26:29 +0000
@@ -1,6 +1,6 @@
1#!/usr/bin/env python31#!/usr/bin/env python3
22
3# ANoise 0.0.27 - http://launchpad.net/anoise3# ANoise 0.0.28 - http://launchpad.net/anoise
4# Copyright (C) 2012-2015 Marcos Alvarez Costales https://launchpad.net/~costales4# Copyright (C) 2012-2015 Marcos Alvarez Costales https://launchpad.net/~costales
5#5#
6# ANoise is free software; you can redistribute it and/or modify6# ANoise is free software; you can redistribute it and/or modify
@@ -29,7 +29,7 @@
29# Setup stage29# Setup stage
30DistUtilsExtra.auto.setup(30DistUtilsExtra.auto.setup(
31 name = "anoise",31 name = "anoise",
32 version = "0.0.27",32 version = "0.0.28",
33 description = "Ambient Noise",33 description = "Ambient Noise",
34 author = "Marcos Alvarez Costales https://launchpad.net/~costales",34 author = "Marcos Alvarez Costales https://launchpad.net/~costales",
35 author_email = "https://launchpad.net/~costales",35 author_email = "https://launchpad.net/~costales",

Subscribers

People subscribed via source and target branches

to all changes: