Merge lp:~cosmos-door/ubuntu/oneiric/gnarwl/fix-ftbfs-lp771112 into lp:ubuntu/oneiric/gnarwl

Proposed by Mitsuya Shibata
Status: Merged
Merged at revision: 9
Proposed branch: lp:~cosmos-door/ubuntu/oneiric/gnarwl/fix-ftbfs-lp771112
Merge into: lp:ubuntu/oneiric/gnarwl
Diff against target: 109 lines (+48/-3)
7 files modified
.pc/applied-patches (+1/-0)
.pc/fix-gcc4.6.patch/src/Makefile (+20/-0)
debian/changelog (+6/-0)
debian/control (+2/-1)
debian/patches/fix-gcc4.6.patch (+16/-0)
debian/patches/series (+1/-0)
src/Makefile (+2/-2)
To merge this branch: bzr merge lp:~cosmos-door/ubuntu/oneiric/gnarwl/fix-ftbfs-lp771112
Reviewer Review Type Date Requested Status
Matthias Klose Approve
Ubuntu branches Pending
Review via email: mp+75559@code.launchpad.net

Description of the change

Fix FTBFS with GCC4.6 (LP: #771112)

This patch move $(LFLAGS) includes -l options to after
source code and object files list within $(CC) statement.

To post a comment you must log in.
Revision history for this message
Matthias Klose (doko) wrote :

it's no GCC-4.6 error, it's the linking order which is wrong. Uploaded with an updated changelog

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.pc/applied-patches'
--- .pc/applied-patches 2010-04-19 19:07:39 +0000
+++ .pc/applied-patches 2011-09-15 15:13:57 +0000
@@ -1,3 +1,4 @@
1doc.patch1doc.patch
2dbaccess.patch2dbaccess.patch
3data-makefile.patch3data-makefile.patch
4fix-gcc4.6.patch
45
=== added directory '.pc/fix-gcc4.6.patch'
=== added file '.pc/fix-gcc4.6.patch/.timestamp'
=== added directory '.pc/fix-gcc4.6.patch/src'
=== added file '.pc/fix-gcc4.6.patch/src/Makefile'
--- .pc/fix-gcc4.6.patch/src/Makefile 1970-01-01 00:00:00 +0000
+++ .pc/fix-gcc4.6.patch/src/Makefile 2011-09-15 15:13:57 +0000
@@ -0,0 +1,20 @@
1OBJ=config.o dbaccess.o util.o mailhandler.o
2SOBJ=config.o dbaccess.o util.o
3
4catch:
5 $(MAKE) -C ..
6
7all: clean compile
8
9compile: $(OBJ) $(SOBJ)
10 $(CC) $(CFLAGS) $(LFLAGS) -o $(BIN) gnarwl.c $(OBJ)
11 $(CC) $(CFLAGS) $(LFLAGS) -o $(SBIN) damnit.c $(SOBJ)
12
13clean:
14 rm -f DEADJOE *.o *~ $(BIN) $(SBIN)
15
16install:
17 mkdir -m 755 -p $(BINDIR) $(SBINDIR)
18 install -m 755 -s $(BIN) $(BINDIR)
19 install -m 755 -s $(SBIN) $(SBINDIR)
20
021
=== modified file 'debian/changelog'
--- debian/changelog 2010-08-04 06:54:49 +0000
+++ debian/changelog 2011-09-15 15:13:57 +0000
@@ -1,3 +1,9 @@
1gnarwl (3.6.dfsg-6ubuntu1) oneiric; urgency=low
2
3 * Fix FTBFS with GCC-4.6 (LP: #771112)
4
5 -- Mitsuya Shibata <mty.shibata@gmail.com> Thu, 15 Sep 2011 16:25:10 +0900
6
1gnarwl (3.6.dfsg-6) unstable; urgency=low7gnarwl (3.6.dfsg-6) unstable; urgency=low
28
3 * Added package ed to list of dependecies ( Closes: #591598 )9 * Added package ed to list of dependecies ( Closes: #591598 )
410
=== modified file 'debian/control'
--- debian/control 2010-08-04 06:54:49 +0000
+++ debian/control 2011-09-15 15:13:57 +0000
@@ -1,7 +1,8 @@
1Source: gnarwl1Source: gnarwl
2Section: mail2Section: mail
3Priority: optional3Priority: optional
4Maintainer: Francesco Zanolin <francesco.zanolin@ingv.it>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Francesco Zanolin <francesco.zanolin@ingv.it>
5Uploaders: Alessandro De Zorzi <lota@nonlontano.it>6Uploaders: Alessandro De Zorzi <lota@nonlontano.it>
6Build-Depends: debhelper (>= 7), libldap2-dev, libgdbm-dev, po-debconf, quilt7Build-Depends: debhelper (>= 7), libldap2-dev, libgdbm-dev, po-debconf, quilt
7Standards-Version: 3.9.08Standards-Version: 3.9.0
89
=== added file 'debian/patches/fix-gcc4.6.patch'
--- debian/patches/fix-gcc4.6.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/fix-gcc4.6.patch 2011-09-15 15:13:57 +0000
@@ -0,0 +1,16 @@
1Fix FTBFS with GCC-4.6 (LP: #771112)
2Index: gnarwl/src/Makefile
3===================================================================
4--- gnarwl.orig/src/Makefile 2011-09-15 16:21:11.912681045 +0900
5+++ gnarwl/src/Makefile 2011-09-15 16:22:10.022701535 +0900
6@@ -7,8 +7,8 @@
7 all: clean compile
8
9 compile: $(OBJ) $(SOBJ)
10- $(CC) $(CFLAGS) $(LFLAGS) -o $(BIN) gnarwl.c $(OBJ)
11- $(CC) $(CFLAGS) $(LFLAGS) -o $(SBIN) damnit.c $(SOBJ)
12+ $(CC) $(CFLAGS) -o $(BIN) gnarwl.c $(OBJ) $(LFLAGS)
13+ $(CC) $(CFLAGS) -o $(SBIN) damnit.c $(SOBJ) $(LFLAGS)
14
15 clean:
16 rm -f DEADJOE *.o *~ $(BIN) $(SBIN)
017
=== modified file 'debian/patches/series'
--- debian/patches/series 2010-03-20 06:33:26 +0000
+++ debian/patches/series 2011-09-15 15:13:57 +0000
@@ -1,3 +1,4 @@
1doc.patch1doc.patch
2dbaccess.patch2dbaccess.patch
3data-makefile.patch3data-makefile.patch
4fix-gcc4.6.patch
45
=== modified file 'src/Makefile'
--- src/Makefile 2004-05-28 19:43:08 +0000
+++ src/Makefile 2011-09-15 15:13:57 +0000
@@ -7,8 +7,8 @@
7all: clean compile7all: clean compile
88
9compile: $(OBJ) $(SOBJ)9compile: $(OBJ) $(SOBJ)
10 $(CC) $(CFLAGS) $(LFLAGS) -o $(BIN) gnarwl.c $(OBJ)10 $(CC) $(CFLAGS) -o $(BIN) gnarwl.c $(OBJ) $(LFLAGS)
11 $(CC) $(CFLAGS) $(LFLAGS) -o $(SBIN) damnit.c $(SOBJ)11 $(CC) $(CFLAGS) -o $(SBIN) damnit.c $(SOBJ) $(LFLAGS)
1212
13clean:13clean:
14 rm -f DEADJOE *.o *~ $(BIN) $(SBIN)14 rm -f DEADJOE *.o *~ $(BIN) $(SBIN)

Subscribers

People subscribed via source and target branches