Merge lp:~compiz-team/compiz/fix-1051595 into lp:compiz/0.9.8

[Sam Spilsbury]

Some problems with make findcompiz_install and make findcompizconfig_install
- make findcompiz_install errors since r3320
- in r3219 installs the findcompiz*.cmake-files with a normal make install,
but not in the Modules directory. This is a) wrong and b) not according to
the message that findcompiz* must be installed with make findcompiz_install.
Patch fixes this, by removing the extra file install with make install, and
cleaning up the building of the findcompiz-target.
(LP: #1051595)

Some problems with make findcompiz_install and make findcompizconfig_install
- make findcompiz_install errors since r3320
- in r3219 installs the findcompiz*.cmake-files with a normal make install,
but not in the Modules directory. This is a) wrong and b) not according to
the message that findcompiz* must be installed with make findcompiz_install.
Patch fixes this, by removing the extra file install with make install, and
cleaning up the building of the findcompiz-target.
(LP: #1051595)

[jenkins (martin-mrazik+qa)]

FAILED: Continuous integration, rev:3378
http://jenkins.qa.ubuntu.com/job/compiz-ci/83/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-ci/./build=pbuilder,distribution=quantal,flavor=amd64/83/console

review: Needs Fixing (continuous-integration)

[Sam Spilsbury (smspillaz)]

Try again jenkins

[jenkins (martin-mrazik+qa)]

FAILED: Continuous integration, rev:3378
http://jenkins.qa.ubuntu.com/job/compiz-ci/84/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-ci/./build=pbuilder,distribution=quantal,flavor=amd64/84/console

review: Needs Fixing (continuous-integration)

[Martin Mrazik (mrazik)]

Do you think this is a problem on jenkins side? TBH I don't see anything obvious.

[Martin Mrazik (mrazik)]

I think this is the line which makes it fail:

dh_install: compiz-dev missing files (debian/tmp/usr/share/cmake*/FindCompiz.cmake), aborting

[Martin Mrazik (mrazik)]

Looks like a packaging/installing issue to me (see also the comment in debian/rules for override_dh_install). Ping me if you still think its a jenkins problem.

[Sam Spilsbury (smspillaz)]

Ah, you're right. I wasn't looking at the right link. We'll need to fix the packaging to handle that I guess

[Daniel van Vugt (vanvugt)]

Not installing share/cmake-2.8/FindCompiz.cmake
will break builds of Unity which needs it for:
  find_package (Compiz REQUIRED)

Or am I missing something?

review: Needs Information

[Daniel van Vugt (vanvugt)]

Confirmed, this breaks Unity builds.

review: Needs Fixing

[Daniel van Vugt (vanvugt)]

Rejecting this because it needs fixing and needs to be resubmitted targeting lp:compiz

Unmerged revisions

3378. By erikjanp on 2012-09-18

Some problems with make findcompiz_install and make findcompizconfig_install
- make findcompiz_install errors since r3320
- in r3219 installs the findcompiz*.cmake-files with a normal make install,
but not in the Modules directory. This is a) wrong and b) not according to
the message that findcompiz* must be installed with make findcompiz_install.
Patch fixes this, by removing the extra file install with make install, and
cleaning up the building of the findcompiz-target.
(LP: #1051595)

=== modified file 'cmake/base.cmake'
--- cmake/base.cmake	2012-05-26 10:52:26 +0000
+++ cmake/base.cmake	2012-09-18 16:30:46 +0000
@@ -49,15 +49,10 @@
         message ("Call \"sudo make findcompiz_install\" to install it.\n")
         compiz_print_configure_footer ()
     endif ()
-    install (FILES
-	     ${CMAKE_CURRENT_SOURCE_DIR}/cmake/FindCompiz.cmake
-	     ${CMAKE_CURRENT_SOURCE_DIR}/cmake/FindOpenGLES2.cmake
-	     DESTINATION
-	     ${CMAKE_INSTALL_PREFIX}/share/cmake-${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION}/)
     add_custom_target (findcompiz_install
-	${CMAKE_COMMAND} -E make_directory ${CMAKE_ROOT}/Modules &&
-	${CMAKE_COMMAND} -E copy ${CMAKE_SOURCE_DIR}/cmake/FindCompiz.cmake ${CMAKE_ROOT}/Modules
-	${CMAKE_COMMAND} -E copy ${CMAKE_SOURCE_DIR}/cmake/FindOpenGLES2.cmake ${CMAKE_ROOT}/Modules
+	COMMAND ${CMAKE_COMMAND} -E make_directory ${CMAKE_ROOT}/Modules
+	COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_SOURCE_DIR}/cmake/FindCompiz.cmake ${CMAKE_ROOT}/Modules
+	COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_SOURCE_DIR}/cmake/FindOpenGLES2.cmake ${CMAKE_ROOT}/Modules
     )
     find_file (_find_compizconfig FindCompizConfig.cmake PATHS ${CMAKE_ROOT}/Modules ${ARGN})
     if (NOT _find_compizconfig)
@@ -67,14 +62,10 @@
 	message ("Call \"sudo make findcompiz_install\" to install it.\n")
 	compiz_print_configure_footer ()
     endif (NOT _find_compizconfig)
-    install (FILES
-	     ${CMAKE_CURRENT_SOURCE_DIR}/compizconfig/libcompizconfig/cmake/FindCompizConfig.cmake
-	     DESTINATION
-	     ${CMAKE_INSTALL_PREFIX}/share/cmake-${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION}/)
     add_custom_target (
 	findcompizconfig_install
-	${CMAKE_COMMAND} -E make_directory ${CMAKE_ROOT}/Modules &&
-	${CMAKE_COMMAND} -E copy ${CMAKE_CURRENT_SOURCE_DIR}/compizconfig/libcompizconfig/cmake/FindCompizConfig.cmake ${CMAKE_ROOT}/Modules
+	COMMAND ${CMAKE_COMMAND} -E make_directory ${CMAKE_ROOT}/Modules
+	COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_CURRENT_SOURCE_DIR}/compizconfig/libcompizconfig/cmake/FindCompizConfig.cmake ${CMAKE_ROOT}/Modules
     )
 endfunction ()