Merge lp:~clissold345/ubuntu-docs/fix-for-1599264 into lp:~ubuntu-core-doc/ubuntu-docs/trunk2017-07-10
Status: | Merged |
---|---|
Merged at revision: | 560 |
Proposed branch: | lp:~clissold345/ubuntu-docs/fix-for-1599264 |
Merge into: | lp:~ubuntu-core-doc/ubuntu-docs/trunk2017-07-10 |
Diff against target: |
124 lines (+33/-41) 2 files modified
ubuntu-help/C/accounts-add.page (+22/-22) ubuntu-help/C/power-lowpower.page (+11/-19) |
To merge this branch: | bzr merge lp:~clissold345/ubuntu-docs/fix-for-1599264 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gunnar Hjalmarsson | Approve | ||
Review via email: mp+308231@code.launchpad.net |
Description of the change
Hi Gunnar, you said you're inclined to drop the whole page. I suggest we keep it. Perhaps I shouldn't have gone ahead and done the change and proposed a merge?
I'm assuming the info in the link I found - I gave the link in the bug report - is correct (eg the action taken on power critically low is shut down, etc). The main purpose of the page (in my opinion) is to say what happens when power is critically low, and it's still useful for users to have that info. The page is short now but it doesn't look ridiculous to me.
As I understand it the shut down action is (still) the default action. It can (still) be changed from the command line (but not now from the GUI). I'd like to say that it's the default action but I can't really do that because then users may ask "What are the other actions and how do I change the default?".
What should we do?
Regarding the updates to accounts-add.page. I started to revise it because I thought the original writer had got a bit confused about whether he/she was "adding an account" or "adding accounts". Then I discovered that the instructions are no longer correct (at least when adding an account for Google). Eg the first button in step 5 is now "Allow" and the second button is now "Grant access" not "Grant Access". The old procedure was also wrong in a few other places (at least in the case of Google). So my version of the procedure should be more accurate than the old version.
The old page used the term "online account" and then later "online service". I think it's probably ok to use "online account" throughout.