Merge lp:~clint-fewbar/pyjuju/namespace-from-env into lp:pyjuju
Proposed by
Clint Byrum
Status: | Work in progress |
---|---|
Proposed branch: | lp:~clint-fewbar/pyjuju/namespace-from-env |
Merge into: | lp:pyjuju |
Diff against target: |
272 lines (+146/-16) 5 files modified
juju/charm/repository.py (+5/-2) juju/charm/tests/test_url.py (+73/-2) juju/charm/url.py (+51/-9) juju/control/deploy.py (+6/-1) juju/control/tests/test_deploy.py (+11/-2) |
To merge this branch: | bzr merge lp:~clint-fewbar/pyjuju/namespace-from-env |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Benjamin Saller (community) | Approve | ||
Review via email: mp+94479@code.launchpad.net |
Description of the change
Default Charm namespace should be overridable by environment variables.
If JUJU_DEFAULT_NS is specified, juju will infer that namespace.
Otherwise, 'cs:' will still be the default.
To post a comment you must log in.
Unmerged revisions
- 475. By Clint Byrum
-
get more defensive about bad namespaces
- 474. By Clint Byrum
-
cleanup, remove improper env setting leftover rom refactoring
- 473. By Clint Byrum
-
documenting usage of JUJU_DEFAULT_NS in deploy.
- 472. By Clint Byrum
-
merging with trunk
- 471. By Clint Byrum
-
move JUJU_DEFAULT_NS to deploy command
- 470. By Clint Byrum
-
handle only user being inferred from environment
- 469. By Clint Byrum
-
working with new proposed ability to override series and user as well
- 468. By Clint Byrum
-
Pull default namespace from environment.
LGTM, it wasn't clear from the mailing list if you agreed about gustavo's suggesstion of calling the env var JUJU_DEFAULT_NS or not, also (and I'm not 100% clear how to reference this now that we've split the docs off) you should add a note to the existing docs about this option.