Merge ~cjwatson/turnip/+git/turnipcake:publish-swift-build-label into ~canonical-launchpad-branches/turnip/+git/turnipcake:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 27132bb9003ce04dfb4dd4cfc44834dc3637522f
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/turnip/+git/turnipcake:publish-swift-build-label
Merge into: ~canonical-launchpad-branches/turnip/+git/turnipcake:master
Diff against target: 47 lines (+11/-1)
2 files modified
Makefile (+1/-1)
publish-to-swift (+10/-0)
Reviewer Review Type Date Requested Status
Thiago F. Pappacena (community) Approve
Review via email: mp+387763@code.launchpad.net

Commit message

Publish last-successful-build-label.txt to Swift

Description of the change

This makes it easier for the Mojo spec to find the most recently-built revision, since it can't necessarily enumerate files in the Swift container.

Same as https://code.launchpad.net/~cjwatson/turnip/+git/turnip/+merge/387744, but for turnipcake.

To post a comment you must log in.
Revision history for this message
Thiago F. Pappacena (pappacena) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/Makefile b/Makefile
index ce0d72f..6c87e2a 100644
--- a/Makefile
+++ b/Makefile
@@ -114,6 +114,6 @@ publish-tarball: build-tarball
114 [ ! -e ~/.config/swift/turnip ] || . ~/.config/swift/turnip; \114 [ ! -e ~/.config/swift/turnip ] || . ~/.config/swift/turnip; \
115 ./publish-to-swift --debug \115 ./publish-to-swift --debug \
116 $(SWIFT_CONTAINER_NAME) $(SWIFT_OBJECT_PATH) \116 $(SWIFT_CONTAINER_NAME) $(SWIFT_OBJECT_PATH) \
117 $(TARBALL_BUILD_PATH)117 $(TARBALL_BUILD_PATH) turnipcake=$(TARBALL_BUILD_LABEL)
118118
119.PHONY: build check clean dist lint run migrate build-tarball publish-tarball119.PHONY: build check clean dist lint run migrate build-tarball publish-tarball
diff --git a/publish-to-swift b/publish-to-swift
index e5cfd59..5a86fe7 100755
--- a/publish-to-swift
+++ b/publish-to-swift
@@ -7,6 +7,7 @@ import os
7import re7import re
8import subprocess8import subprocess
9import sys9import sys
10import tempfile
1011
1112
12def ensure_container_privs(container_name):13def ensure_container_privs(container_name):
@@ -75,6 +76,7 @@ def main():
75 parser.add_argument("container_name")76 parser.add_argument("container_name")
76 parser.add_argument("swift_object_path")77 parser.add_argument("swift_object_path")
77 parser.add_argument("local_path")78 parser.add_argument("local_path")
79 parser.add_argument("build_label")
78 args = parser.parse_args()80 args = parser.parse_args()
7981
80 if args.debug:82 if args.debug:
@@ -118,6 +120,14 @@ def main():
118 args.container_name, args.swift_object_path, args.local_path,120 args.container_name, args.swift_object_path, args.local_path,
119 overwrite=overwrite)121 overwrite=overwrite)
120122
123 with tempfile.TemporaryDirectory() as tmpdir:
124 filename = "last-successful-build-label.txt"
125 with open(os.path.join(tmpdir, filename), "w") as f:
126 f.write(args.build_label)
127 publish_file_to_swift(
128 args.container_name, filename, os.path.join(tmpdir, filename),
129 overwrite=True)
130
121131
122if __name__ == "__main__":132if __name__ == "__main__":
123 main()133 main()

Subscribers

People subscribed via source and target branches