Merge lp:~cjwatson/launchpad/git-private-code-import into lp:launchpad
Proposed by
Colin Watson
Status: | Merged |
---|---|
Merged at revision: | 18764 |
Proposed branch: | lp:~cjwatson/launchpad/git-private-code-import |
Merge into: | lp:launchpad |
Diff against target: |
95 lines (+50/-7) 2 files modified
lib/lp/code/xmlrpc/git.py (+2/-1) lib/lp/code/xmlrpc/tests/test_git.py (+48/-6) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/git-private-code-import |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Daniel Manrique (community) | Abstain | ||
Review via email: mp+353874@code.launchpad.net |
Commit message
Fix incorrect visibility check that broke code imports targeted at private Git repositories.
To post a comment you must log in.
LGTM, thanks! I'm not a Launchpad code reviewer and I don't know this codebase well enough, so I'll abstain, but this makes sense.