Merge ~cjwatson/launchpad:py3-test-sprints-stringio into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 5cbb02017968192b2714a3bb0cc40c9a2da90db4
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:py3-test-sprints-stringio
Merge into: launchpad:master
Diff against target: 23 lines (+2/-3)
1 file modified
lib/lp/blueprints/stories/sprints/xx-sprints.txt (+2/-3)
Reviewer Review Type Date Requested Status
Cristian Gonzalez (community) Approve
Review via email: mp+398926@code.launchpad.net

Commit message

Port xx-sprints.txt to six.StringIO

To post a comment you must log in.
Revision history for this message
Cristian Gonzalez (cristiangsp) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/lib/lp/blueprints/stories/sprints/xx-sprints.txt b/lib/lp/blueprints/stories/sprints/xx-sprints.txt
index f1b0ced..cfda51f 100644
--- a/lib/lp/blueprints/stories/sprints/xx-sprints.txt
+++ b/lib/lp/blueprints/stories/sprints/xx-sprints.txt
@@ -489,8 +489,7 @@ First, we add a couple of IRC nicknames for Carlos.
489The resulting CSV file lists physical attendance correctly.489The resulting CSV file lists physical attendance correctly.
490490
491 >>> import csv491 >>> import csv
492 >>> from StringIO import StringIO492 >>> ubz_csv = list(csv.DictReader(six.StringIO(browser.contents)))
493 >>> ubz_csv = list(csv.DictReader(StringIO(browser.contents)))
494 >>> [(row["Launchpad username"], row["Physically present"])493 >>> [(row["Launchpad username"], row["Physically present"])
495 ... for row in ubz_csv]494 ... for row in ubz_csv]
496 [('carlos', 'True'), ('salgado', 'False'), ('name12', 'True')]495 [('carlos', 'True'), ('salgado', 'False'), ('name12', 'True')]
@@ -523,7 +522,7 @@ as attending remotely.
523 >>> browser.getControl('Register').click()522 >>> browser.getControl('Register').click()
524523
525 >>> browser.getLink('Export attendees to CSV').click()524 >>> browser.getLink('Export attendees to CSV').click()
526 >>> ltsp_csv = list(csv.DictReader(StringIO(browser.contents)))525 >>> ltsp_csv = list(csv.DictReader(six.StringIO(browser.contents)))
527 >>> [(row["Launchpad username"], row["Physically present"])526 >>> [(row["Launchpad username"], row["Physically present"])
528 ... for row in ltsp_csv]527 ... for row in ltsp_csv]
529 [('name12', 'False')]528 [('name12', 'False')]

Subscribers

People subscribed via source and target branches

to status/vote changes: