Merge ~cjwatson/launchpad:no-system-site-packages into launchpad:master
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 54684b3d58b280e1f2e8c85d61a64be4fbc5510b |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:no-system-site-packages |
Merge into: | launchpad:master |
Diff against target: |
188 lines (+88/-17) 6 files modified
Makefile (+8/-7) doc/pip.txt (+0/-1) setup-requirements.txt (+0/-7) setup.py (+1/-2) system-packages.txt (+32/-0) utilities/link-system-packages.py (+47/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ioana Lasc (community) | Approve | ||
Review via email: mp+378946@code.launchpad.net |
Commit message
Stop using --system-
Description of the change
We've been using "virtualenv --system-
However, with recent versions of pip and Python 3, the situation gets worse. https:/
(On Python 2 we get away with this by luck, because distutils.
Installing everything properly in the virtualenv is also difficult. Several of the ones that remain don't exist as wheels or in another form that pip can install. We could fake this up (I went so far as to prepare a script to convert the installed version of python-apt into a wheel), but this would incur a significant maintenance burden.
Instead, symlink packages from the system site-packages directory into the virtualenv in "make compile". It's conceivable that this might confuse pip slightly, but so far it doesn't seem to, and everything else works fine.
This shouldn't be landed until https:/
LGTM