Merge lp:~cjcurran/indicator-sound/rogue-mute into lp:~indicator-applet-developers/indicator-sound/trunk_3
- rogue-mute
- Merge into trunk_3
Proposed by
Conor Curran
Status: | Merged |
---|---|
Merged at revision: | 228 |
Proposed branch: | lp:~cjcurran/indicator-sound/rogue-mute |
Merge into: | lp:~indicator-applet-developers/indicator-sound/trunk_3 |
Diff against target: |
288 lines (+52/-43) 6 files modified
src/playlists-menu-item.vala (+1/-1) src/slider-menu-item.c (+9/-6) src/sound-service.c (+2/-0) src/voip-input-menu-item.c (+4/-1) src/voip-input-widget.c (+5/-2) src/volume-widget.c (+31/-33) |
To merge this branch: | bzr merge lp:~cjcurran/indicator-sound/rogue-mute |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kalle Valo (community) | Approve | ||
Review via email: mp+54414@code.launchpad.net |
Commit message
Description of the change
Places more added protection in the slider widgets so as any irregular spam coming from dbusmenu will not find its way onto a gtk_range_
Refactored the volume widget so as the mute property is a boolean (makes sense) and updated the various handle event calls so as each source can be identified via the name param.
To post a comment you must log in.
Revision history for this message
Conor Curran (cjcurran) wrote : | # |
Oh well spotted.
- 231. By Conor Curran
-
tidy up
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | === modified file 'src/playlists-menu-item.vala' | |||
2 | --- src/playlists-menu-item.vala 2011-03-17 16:10:03 +0000 | |||
3 | +++ src/playlists-menu-item.vala 2011-03-23 10:16:44 +0000 | |||
4 | @@ -80,7 +80,7 @@ | |||
5 | 80 | if (this.root_item.property_get (MENUITEM_PATH) == item.property_get (MENUITEM_PATH)){ | 80 | if (this.root_item.property_get (MENUITEM_PATH) == item.property_get (MENUITEM_PATH)){ |
6 | 81 | this.root_item.property_set (MENUITEM_PROP_LABEL, _("Choose Playlist")); | 81 | this.root_item.property_set (MENUITEM_PROP_LABEL, _("Choose Playlist")); |
7 | 82 | } | 82 | } |
9 | 83 | this.root_item.child_delete (item); | 83 | this.root_item.child_delete (item); |
10 | 84 | } | 84 | } |
11 | 85 | } | 85 | } |
12 | 86 | } | 86 | } |
13 | 87 | 87 | ||
14 | === modified file 'src/slider-menu-item.c' | |||
15 | --- src/slider-menu-item.c 2011-03-21 13:04:13 +0000 | |||
16 | +++ src/slider-menu-item.c 2011-03-23 10:16:44 +0000 | |||
17 | @@ -69,9 +69,6 @@ | |||
18 | 69 | static void | 69 | static void |
19 | 70 | slider_menu_item_init (SliderMenuItem *self) | 70 | slider_menu_item_init (SliderMenuItem *self) |
20 | 71 | { | 71 | { |
21 | 72 | /* | ||
22 | 73 | g_debug("Building new Slider Menu Item"); | ||
23 | 74 | */ | ||
24 | 75 | dbusmenu_menuitem_property_set( DBUSMENU_MENUITEM(self), | 72 | dbusmenu_menuitem_property_set( DBUSMENU_MENUITEM(self), |
25 | 76 | DBUSMENU_MENUITEM_PROP_TYPE, | 73 | DBUSMENU_MENUITEM_PROP_TYPE, |
26 | 77 | DBUSMENU_VOLUME_MENUITEM_TYPE ); | 74 | DBUSMENU_VOLUME_MENUITEM_TYPE ); |
27 | @@ -108,11 +105,13 @@ | |||
28 | 108 | 105 | ||
29 | 109 | SliderMenuItemPrivate* priv = SLIDER_MENU_ITEM_GET_PRIVATE (SLIDER_MENU_ITEM (mi)); | 106 | SliderMenuItemPrivate* priv = SLIDER_MENU_ITEM_GET_PRIVATE (SLIDER_MENU_ITEM (mi)); |
30 | 110 | gdouble volume_input = g_variant_get_double (value); | 107 | gdouble volume_input = g_variant_get_double (value); |
31 | 108 | |||
32 | 111 | /* | 109 | /* |
33 | 112 | g_debug ("slider menu item handle event with value %f on name %s", | 110 | g_debug ("slider menu item handle event with value %f on name %s", |
34 | 113 | volume_input, | 111 | volume_input, |
35 | 114 | name); | 112 | name); |
36 | 115 | */ | 113 | */ |
37 | 114 | |||
38 | 116 | slider_menu_item_update_volume (SLIDER_MENU_ITEM (mi), volume_input); | 115 | slider_menu_item_update_volume (SLIDER_MENU_ITEM (mi), volume_input); |
39 | 117 | device_ensure_sink_is_unmuted (priv->a_sink); | 116 | device_ensure_sink_is_unmuted (priv->a_sink); |
40 | 118 | } | 117 | } |
41 | @@ -135,7 +134,7 @@ | |||
42 | 135 | dbusmenu_menuitem_property_set_variant (DBUSMENU_MENUITEM(self), | 134 | dbusmenu_menuitem_property_set_variant (DBUSMENU_MENUITEM(self), |
43 | 136 | DBUSMENU_VOLUME_MENUITEM_LEVEL, | 135 | DBUSMENU_VOLUME_MENUITEM_LEVEL, |
44 | 137 | new_volume); | 136 | new_volume); |
46 | 138 | GVariant* new_mute_update = g_variant_new_int32 (update->mute); | 137 | GVariant* new_mute_update = g_variant_new_boolean (update->mute == 1); |
47 | 139 | dbusmenu_menuitem_property_set_variant (DBUSMENU_MENUITEM(self), | 138 | dbusmenu_menuitem_property_set_variant (DBUSMENU_MENUITEM(self), |
48 | 140 | DBUSMENU_VOLUME_MENUITEM_MUTE, | 139 | DBUSMENU_VOLUME_MENUITEM_MUTE, |
49 | 141 | new_mute_update); | 140 | new_mute_update); |
50 | @@ -147,6 +146,7 @@ | |||
51 | 147 | static void | 146 | static void |
52 | 148 | slider_menu_item_update_volume (SliderMenuItem* self, gdouble percent) | 147 | slider_menu_item_update_volume (SliderMenuItem* self, gdouble percent) |
53 | 149 | { | 148 | { |
54 | 149 | |||
55 | 150 | /* | 150 | /* |
56 | 151 | g_debug ("slider menu item update volume - about to set the volume to %f", percent); | 151 | g_debug ("slider menu item update volume - about to set the volume to %f", percent); |
57 | 152 | */ | 152 | */ |
58 | @@ -177,18 +177,21 @@ | |||
59 | 177 | gdouble volume_percent = ((gdouble) vol * 100) / PA_VOLUME_NORM; | 177 | gdouble volume_percent = ((gdouble) vol * 100) / PA_VOLUME_NORM; |
60 | 178 | 178 | ||
61 | 179 | GVariant* new_volume = g_variant_new_double (volume_percent); | 179 | GVariant* new_volume = g_variant_new_double (volume_percent); |
62 | 180 | |||
63 | 180 | /* | 181 | /* |
64 | 181 | g_debug ("slider menu item update - volume update to ui to %f", volume_percent); | 182 | g_debug ("slider menu item update - volume update to ui to %f", volume_percent); |
65 | 182 | */ | 183 | */ |
66 | 184 | |||
67 | 183 | dbusmenu_menuitem_property_set_variant (DBUSMENU_MENUITEM(self), | 185 | dbusmenu_menuitem_property_set_variant (DBUSMENU_MENUITEM(self), |
68 | 184 | DBUSMENU_VOLUME_MENUITEM_LEVEL, | 186 | DBUSMENU_VOLUME_MENUITEM_LEVEL, |
69 | 185 | new_volume); | 187 | new_volume); |
70 | 188 | |||
71 | 186 | if (priv->mute != update->mute){ | 189 | if (priv->mute != update->mute){ |
72 | 187 | priv->mute = update->mute; | 190 | priv->mute = update->mute; |
73 | 188 | /* | 191 | /* |
74 | 189 | g_debug ("volume menu item - update - mute on ui = %i", update->mute); | 192 | g_debug ("volume menu item - update - mute on ui = %i", update->mute); |
75 | 190 | */ | 193 | */ |
77 | 191 | GVariant* new_mute_update = g_variant_new_int32 (update->mute); | 194 | GVariant* new_mute_update = g_variant_new_boolean (update->mute == 1); |
78 | 192 | dbusmenu_menuitem_property_set_variant (DBUSMENU_MENUITEM(self), | 195 | dbusmenu_menuitem_property_set_variant (DBUSMENU_MENUITEM(self), |
79 | 193 | DBUSMENU_VOLUME_MENUITEM_MUTE, | 196 | DBUSMENU_VOLUME_MENUITEM_MUTE, |
80 | 194 | new_mute_update); | 197 | new_mute_update); |
81 | @@ -241,4 +244,4 @@ | |||
82 | 241 | SliderMenuItemPrivate* priv = SLIDER_MENU_ITEM_GET_PRIVATE (self); | 244 | SliderMenuItemPrivate* priv = SLIDER_MENU_ITEM_GET_PRIVATE (self); |
83 | 242 | priv->a_sink = sink; | 245 | priv->a_sink = sink; |
84 | 243 | return self; | 246 | return self; |
85 | 244 | } | ||
86 | 245 | \ No newline at end of file | 247 | \ No newline at end of file |
87 | 248 | } | ||
88 | 246 | 249 | ||
89 | === modified file 'src/sound-service.c' | |||
90 | --- src/sound-service.c 2011-03-21 16:01:03 +0000 | |||
91 | +++ src/sound-service.c 2011-03-23 10:16:44 +0000 | |||
92 | @@ -22,6 +22,8 @@ | |||
93 | 22 | #include "sound-service-dbus.h" | 22 | #include "sound-service-dbus.h" |
94 | 23 | #include "music-player-bridge.h" | 23 | #include "music-player-bridge.h" |
95 | 24 | 24 | ||
96 | 25 | #include <locale.h> | ||
97 | 26 | |||
98 | 25 | static GMainLoop *mainloop = NULL; | 27 | static GMainLoop *mainloop = NULL; |
99 | 26 | 28 | ||
100 | 27 | /**********************************************************************************************************************/ | 29 | /**********************************************************************************************************************/ |
101 | 28 | 30 | ||
102 | === modified file 'src/voip-input-menu-item.c' | |||
103 | --- src/voip-input-menu-item.c 2011-03-14 19:47:59 +0000 | |||
104 | +++ src/voip-input-menu-item.c 2011-03-23 10:16:44 +0000 | |||
105 | @@ -73,7 +73,6 @@ | |||
106 | 73 | static void | 73 | static void |
107 | 74 | voip_input_menu_item_init (VoipInputMenuItem *self) | 74 | voip_input_menu_item_init (VoipInputMenuItem *self) |
108 | 75 | { | 75 | { |
109 | 76 | g_debug("Building new Slider Menu Item"); | ||
110 | 77 | dbusmenu_menuitem_property_set( DBUSMENU_MENUITEM(self), | 76 | dbusmenu_menuitem_property_set( DBUSMENU_MENUITEM(self), |
111 | 78 | DBUSMENU_MENUITEM_PROP_TYPE, | 77 | DBUSMENU_MENUITEM_PROP_TYPE, |
112 | 79 | DBUSMENU_VOIP_INPUT_MENUITEM_TYPE ); | 78 | DBUSMENU_VOIP_INPUT_MENUITEM_TYPE ); |
113 | @@ -117,7 +116,9 @@ | |||
114 | 117 | if (value != NULL){ | 116 | if (value != NULL){ |
115 | 118 | if (IS_VOIP_INPUT_MENU_ITEM (mi)) { | 117 | if (IS_VOIP_INPUT_MENU_ITEM (mi)) { |
116 | 119 | VoipInputMenuItemPrivate* priv = VOIP_INPUT_MENU_ITEM_GET_PRIVATE (VOIP_INPUT_MENU_ITEM (mi)); | 118 | VoipInputMenuItemPrivate* priv = VOIP_INPUT_MENU_ITEM_GET_PRIVATE (VOIP_INPUT_MENU_ITEM (mi)); |
117 | 119 | /* | ||
118 | 120 | g_debug ("Handle event in the voip input level backend instance - %f", percent); | 120 | g_debug ("Handle event in the voip input level backend instance - %f", percent); |
119 | 121 | */ | ||
120 | 121 | pa_cvolume new_volume; | 122 | pa_cvolume new_volume; |
121 | 122 | pa_cvolume_init(&new_volume); | 123 | pa_cvolume_init(&new_volume); |
122 | 123 | new_volume.channels = 1; | 124 | new_volume.channels = 1; |
123 | @@ -167,7 +168,9 @@ | |||
124 | 167 | // Only send over the mute updates if the state has changed. | 168 | // Only send over the mute updates if the state has changed. |
125 | 168 | // in this order - volume first mute last!! | 169 | // in this order - volume first mute last!! |
126 | 169 | if (priv->mute != source->mute){ | 170 | if (priv->mute != source->mute){ |
127 | 171 | /* | ||
128 | 170 | g_debug ("voip menu item - update - mute = %i", priv->mute); | 172 | g_debug ("voip menu item - update - mute = %i", priv->mute); |
129 | 173 | */ | ||
130 | 171 | GVariant* new_mute_update = g_variant_new_int32 (source->mute); | 174 | GVariant* new_mute_update = g_variant_new_int32 (source->mute); |
131 | 172 | dbusmenu_menuitem_property_set_variant (DBUSMENU_MENUITEM(item), | 175 | dbusmenu_menuitem_property_set_variant (DBUSMENU_MENUITEM(item), |
132 | 173 | DBUSMENU_VOIP_INPUT_MENUITEM_MUTE, | 176 | DBUSMENU_VOIP_INPUT_MENUITEM_MUTE, |
133 | 174 | 177 | ||
134 | === modified file 'src/voip-input-widget.c' | |||
135 | --- src/voip-input-widget.c 2011-03-21 13:04:13 +0000 | |||
136 | +++ src/voip-input-widget.c 2011-03-23 10:16:44 +0000 | |||
137 | @@ -141,6 +141,7 @@ | |||
138 | 141 | } | 141 | } |
139 | 142 | if(g_ascii_strcasecmp(DBUSMENU_VOIP_INPUT_MENUITEM_MUTE, property) == 0){ | 142 | if(g_ascii_strcasecmp(DBUSMENU_VOIP_INPUT_MENUITEM_MUTE, property) == 0){ |
140 | 143 | if(priv->grabbed == FALSE){ | 143 | if(priv->grabbed == FALSE){ |
141 | 144 | g_return_if_fail (g_variant_is_of_type (value, G_VARIANT_TYPE_INT32)); | ||
142 | 144 | GtkWidget *slider = ido_scale_menu_item_get_scale((IdoScaleMenuItem*)priv->ido_voip_input_slider); | 145 | GtkWidget *slider = ido_scale_menu_item_get_scale((IdoScaleMenuItem*)priv->ido_voip_input_slider); |
143 | 145 | GtkRange *range = (GtkRange*)slider; | 146 | GtkRange *range = (GtkRange*)slider; |
144 | 146 | gint update = g_variant_get_int32 (value); | 147 | gint update = g_variant_get_int32 (value); |
145 | @@ -149,8 +150,10 @@ | |||
146 | 149 | level = 0; | 150 | level = 0; |
147 | 150 | } | 151 | } |
148 | 151 | else{ | 152 | else{ |
151 | 152 | level = g_variant_get_double (dbusmenu_menuitem_property_get_variant (priv->twin_item, | 153 | GVariant* variant = dbusmenu_menuitem_property_get_variant (priv->twin_item, |
152 | 153 | DBUSMENU_VOIP_INPUT_MENUITEM_LEVEL)); | 154 | DBUSMENU_VOIP_INPUT_MENUITEM_LEVEL); |
153 | 155 | g_return_if_fail (g_variant_is_of_type (variant, G_VARIANT_TYPE_DOUBLE)); | ||
154 | 156 | level = g_variant_get_double (variant); | ||
155 | 154 | } | 157 | } |
156 | 155 | gtk_range_set_value(range, level); | 158 | gtk_range_set_value(range, level); |
157 | 156 | 159 | ||
158 | 157 | 160 | ||
159 | === modified file 'src/volume-widget.c' | |||
160 | --- src/volume-widget.c 2011-03-21 13:04:13 +0000 | |||
161 | +++ src/volume-widget.c 2011-03-23 10:16:44 +0000 | |||
162 | @@ -128,48 +128,48 @@ | |||
163 | 128 | volume_widget_property_update( DbusmenuMenuitem* item, gchar* property, | 128 | volume_widget_property_update( DbusmenuMenuitem* item, gchar* property, |
164 | 129 | GVariant* value, gpointer userdata) | 129 | GVariant* value, gpointer userdata) |
165 | 130 | { | 130 | { |
167 | 131 | g_return_if_fail (IS_VOLUME_WIDGET (userdata)); | 131 | g_return_if_fail (IS_VOLUME_WIDGET(userdata)); |
168 | 132 | VolumeWidget* mitem = VOLUME_WIDGET(userdata); | 132 | VolumeWidget* mitem = VOLUME_WIDGET(userdata); |
169 | 133 | VolumeWidgetPrivate * priv = VOLUME_WIDGET_GET_PRIVATE(mitem); | 133 | VolumeWidgetPrivate * priv = VOLUME_WIDGET_GET_PRIVATE(mitem); |
170 | 134 | |||
171 | 134 | if(g_ascii_strcasecmp(DBUSMENU_VOLUME_MENUITEM_LEVEL, property) == 0){ | 135 | if(g_ascii_strcasecmp(DBUSMENU_VOLUME_MENUITEM_LEVEL, property) == 0){ |
172 | 135 | g_return_if_fail (g_variant_is_of_type (value, G_VARIANT_TYPE_DOUBLE) ); | 136 | g_return_if_fail (g_variant_is_of_type (value, G_VARIANT_TYPE_DOUBLE) ); |
173 | 136 | if(priv->grabbed == FALSE){ | 137 | if(priv->grabbed == FALSE){ |
174 | 137 | GtkWidget *slider = ido_scale_menu_item_get_scale((IdoScaleMenuItem*)priv->ido_volume_slider); | 138 | GtkWidget *slider = ido_scale_menu_item_get_scale((IdoScaleMenuItem*)priv->ido_volume_slider); |
175 | 138 | GtkRange *range = (GtkRange*)slider; | 139 | GtkRange *range = (GtkRange*)slider; |
176 | 139 | gdouble update = g_variant_get_double (value); | 140 | gdouble update = g_variant_get_double (value); |
177 | 140 | /* | ||
178 | 141 | g_debug ("volume widget volume prop update with %f", update); | ||
179 | 142 | */ | ||
180 | 143 | gtk_range_set_value(range, update); | 141 | gtk_range_set_value(range, update); |
181 | 142 | /* | ||
182 | 143 | g_debug ("volume-widget::volume_widget_property_update - volume - value %f", update); | ||
183 | 144 | */ | ||
184 | 144 | update_accessible_desc(priv->indicator); | 145 | update_accessible_desc(priv->indicator); |
185 | 145 | } | 146 | } |
186 | 146 | } | 147 | } |
192 | 147 | if(g_ascii_strcasecmp(DBUSMENU_VOLUME_MENUITEM_MUTE, property) == 0){ | 148 | else if(g_ascii_strcasecmp(DBUSMENU_VOLUME_MENUITEM_MUTE, property) == 0){ |
193 | 148 | /* | 149 | g_return_if_fail (g_variant_is_of_type (value, G_VARIANT_TYPE_BOOLEAN)); |
189 | 149 | g_debug ("volume widget - mute update "); | ||
190 | 150 | */ | ||
191 | 151 | g_return_if_fail (g_variant_is_of_type (value, G_VARIANT_TYPE_INT32) ); | ||
194 | 152 | if(priv->grabbed == FALSE){ | 150 | if(priv->grabbed == FALSE){ |
195 | 153 | GtkWidget *slider = ido_scale_menu_item_get_scale((IdoScaleMenuItem*)priv->ido_volume_slider); | 151 | GtkWidget *slider = ido_scale_menu_item_get_scale((IdoScaleMenuItem*)priv->ido_volume_slider); |
196 | 154 | GtkRange *range = (GtkRange*)slider; | 152 | GtkRange *range = (GtkRange*)slider; |
198 | 155 | gint update = g_variant_get_int32 (value); | 153 | gboolean update = g_variant_get_boolean (value); |
199 | 156 | gdouble level; | 154 | gdouble level; |
200 | 157 | 155 | ||
206 | 158 | /* | 156 | if (update == TRUE){ |
202 | 159 | g_debug ("volume widget - mute update %i", update); | ||
203 | 160 | */ | ||
204 | 161 | |||
205 | 162 | if (update == 1){ | ||
207 | 163 | level = 0; | 157 | level = 0; |
208 | 164 | } | 158 | } |
209 | 165 | else{ | 159 | else{ |
212 | 166 | level = g_variant_get_double (dbusmenu_menuitem_property_get_variant (priv->twin_item, | 160 | GVariant* variant = dbusmenu_menuitem_property_get_variant (priv->twin_item, |
213 | 167 | DBUSMENU_VOLUME_MENUITEM_LEVEL)); | 161 | DBUSMENU_VOLUME_MENUITEM_LEVEL); |
214 | 162 | /* | ||
215 | 163 | g_debug ("variant for the volume - is it null = %i", variant == NULL); | ||
216 | 164 | */ | ||
217 | 165 | g_return_if_fail (g_variant_is_of_type (variant, G_VARIANT_TYPE_DOUBLE) ); | ||
218 | 166 | |||
219 | 167 | level = g_variant_get_double (variant); | ||
220 | 168 | } | 168 | } |
221 | 169 | /* | ||
222 | 170 | g_debug ("volume-widget::volume_widget_property_update - mute - value %i and level = %f", update, level); | ||
223 | 171 | */ | ||
224 | 169 | gtk_range_set_value(range, level); | 172 | gtk_range_set_value(range, level); |
225 | 170 | /* | ||
226 | 171 | g_debug ("volume-widget - update mute with value %i", update); | ||
227 | 172 | */ | ||
228 | 173 | } | 173 | } |
229 | 174 | } | 174 | } |
230 | 175 | } | 175 | } |
231 | @@ -185,13 +185,13 @@ | |||
232 | 185 | G_CALLBACK(volume_widget_property_update), self); | 185 | G_CALLBACK(volume_widget_property_update), self); |
233 | 186 | gdouble initial_level = g_variant_get_double (dbusmenu_menuitem_property_get_variant(twin_item, | 186 | gdouble initial_level = g_variant_get_double (dbusmenu_menuitem_property_get_variant(twin_item, |
234 | 187 | DBUSMENU_VOLUME_MENUITEM_LEVEL)); | 187 | DBUSMENU_VOLUME_MENUITEM_LEVEL)); |
237 | 188 | gint initial_mute = g_variant_get_int32 (dbusmenu_menuitem_property_get_variant(twin_item, | 188 | gboolean initial_mute = g_variant_get_boolean (dbusmenu_menuitem_property_get_variant(twin_item, |
238 | 189 | DBUSMENU_VOLUME_MENUITEM_MUTE)); | 189 | DBUSMENU_VOLUME_MENUITEM_MUTE)); |
239 | 190 | 190 | ||
240 | 191 | //g_debug("volume_widget_set_twin_item initial level = %f", initial_level); | 191 | //g_debug("volume_widget_set_twin_item initial level = %f", initial_level); |
241 | 192 | GtkWidget *slider = ido_scale_menu_item_get_scale((IdoScaleMenuItem*)priv->ido_volume_slider); | 192 | GtkWidget *slider = ido_scale_menu_item_get_scale((IdoScaleMenuItem*)priv->ido_volume_slider); |
242 | 193 | GtkRange *range = (GtkRange*)slider; | 193 | GtkRange *range = (GtkRange*)slider; |
244 | 194 | if(initial_mute == 1){ | 194 | if(initial_mute == TRUE){ |
245 | 195 | initial_level = 0; | 195 | initial_level = 0; |
246 | 196 | } | 196 | } |
247 | 197 | gtk_range_set_value(range, initial_level); | 197 | gtk_range_set_value(range, initial_level); |
248 | @@ -206,9 +206,11 @@ | |||
249 | 206 | { | 206 | { |
250 | 207 | g_return_val_if_fail (IS_VOLUME_WIDGET (user_data), FALSE); | 207 | g_return_val_if_fail (IS_VOLUME_WIDGET (user_data), FALSE); |
251 | 208 | VolumeWidget* mitem = VOLUME_WIDGET(user_data); | 208 | VolumeWidget* mitem = VOLUME_WIDGET(user_data); |
252 | 209 | |||
253 | 209 | /* | 210 | /* |
254 | 210 | g_debug ("changed value %f", new_value); | 211 | g_debug ("changed value %f", new_value); |
255 | 211 | */ | 212 | */ |
256 | 213 | |||
257 | 212 | volume_widget_update(mitem, new_value, "change-value"); | 214 | volume_widget_update(mitem, new_value, "change-value"); |
258 | 213 | return FALSE; | 215 | return FALSE; |
259 | 214 | } | 216 | } |
260 | @@ -222,22 +224,18 @@ | |||
261 | 222 | { | 224 | { |
262 | 223 | 225 | ||
263 | 224 | g_return_val_if_fail (IS_VOLUME_WIDGET (user_data), FALSE); | 226 | g_return_val_if_fail (IS_VOLUME_WIDGET (user_data), FALSE); |
265 | 225 | VolumeWidget* mitem = VOLUME_WIDGET(user_data); | 227 | VolumeWidget* mitem = VOLUME_WIDGET (user_data); |
266 | 226 | VolumeWidgetPrivate * priv = VOLUME_WIDGET_GET_PRIVATE(mitem); | 228 | VolumeWidgetPrivate * priv = VOLUME_WIDGET_GET_PRIVATE(mitem); |
267 | 227 | GtkWidget *slider = ido_scale_menu_item_get_scale((IdoScaleMenuItem*)priv->ido_volume_slider); | 229 | GtkWidget *slider = ido_scale_menu_item_get_scale((IdoScaleMenuItem*)priv->ido_volume_slider); |
268 | 228 | gdouble current_value = CLAMP(gtk_range_get_value(GTK_RANGE(slider)), 0, 100); | 230 | gdouble current_value = CLAMP(gtk_range_get_value(GTK_RANGE(slider)), 0, 100); |
277 | 229 | /* | 231 | |
278 | 230 | g_debug ("value changed %f", gtk_range_get_value(GTK_RANGE(slider))); | 232 | gboolean mute = g_variant_get_boolean (dbusmenu_menuitem_property_get_variant (priv->twin_item, |
279 | 231 | */ | 233 | DBUSMENU_VOLUME_MENUITEM_MUTE)); |
280 | 232 | 234 | if((current_value == 0 && mute == FALSE) || current_value == 100){ | |
273 | 233 | gint mute = g_variant_get_int32 (dbusmenu_menuitem_property_get_variant (priv->twin_item, | ||
274 | 234 | DBUSMENU_VOLUME_MENUITEM_MUTE)); | ||
275 | 235 | |||
276 | 236 | if((current_value == 0 && mute != 1) || current_value == 100){ | ||
281 | 237 | /* | 235 | /* |
282 | 238 | g_debug ("value changed - actual set %f", current_value); | 236 | g_debug ("value changed - actual set %f", current_value); |
283 | 239 | */ | 237 | */ |
285 | 240 | volume_widget_update(mitem, current_value, "value-changed"); | 238 | volume_widget_update (mitem, current_value, "value-changed"); |
286 | 241 | } | 239 | } |
287 | 242 | 240 | ||
288 | 243 | return FALSE; | 241 | return FALSE; |
Commented out code:
//this. root_item. child_delete (item);
Otherwise looks good. Approved.