Merge lp:~charlesk/indicator-session/lp-1085100 into lp:indicator-session/13.04

Proposed by Charles Kerr
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 382
Merged at revision: 379
Proposed branch: lp:~charlesk/indicator-session/lp-1085100
Merge into: lp:indicator-session/13.04
Diff against target: 78 lines (+11/-12)
3 files modified
configure.ac (+8/-9)
debian/changelog (+3/-0)
debian/control (+0/-3)
To merge this branch: bzr merge lp:~charlesk/indicator-session/lp-1085100
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Mathieu Trudel-Lapierre Approve
Review via email: mp+137252@code.launchpad.net

Commit message

i-session doesn't use polkit or packagekit anymore, so don't refer to them in configure.ac or debian/*.

Description of the change

i-session doesn't use polkit or packagekit anymore, so don't refer to them in configure.ac or debian/*.

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Seems fine if it's indeed not used anymore.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure.ac'
--- configure.ac 2012-11-29 22:09:57 +0000
+++ configure.ac 2012-11-30 16:35:26 +0000
@@ -30,7 +30,6 @@
30GTK_REQUIRED_VERSION=3.030GTK_REQUIRED_VERSION=3.0
31INDICATOR_REQUIRED_VERSION=0.3.1931INDICATOR_REQUIRED_VERSION=0.3.19
32DBUSMENUGTK_REQUIRED_VERSION=0.5.9032DBUSMENUGTK_REQUIRED_VERSION=0.5.90
33POLKIT_REQUIRED_VERSION=0.92
34DBUSTEST_REQUIRED_VERSION=0.0.533DBUSTEST_REQUIRED_VERSION=0.0.5
35DBUSMENUGLIB_REQUIRED_VERSION=0.1.134DBUSMENUGLIB_REQUIRED_VERSION=0.1.1
3635
@@ -47,8 +46,7 @@
47 dbusmenu-glib-0.4 >= $DBUSMENUGLIB_REQUIRED_VERSION46 dbusmenu-glib-0.4 >= $DBUSMENUGLIB_REQUIRED_VERSION
48 dbusmenu-gtk3-0.4 >= $DBUSMENUGTK_REQUIRED_VERSION47 dbusmenu-gtk3-0.4 >= $DBUSMENUGTK_REQUIRED_VERSION
49 gio-unix-2.048 gio-unix-2.0
50 indicator3-0.4 >= $INDICATOR_REQUIRED_VERSION49 indicator3-0.4 >= $INDICATOR_REQUIRED_VERSION)
51 packagekit-glib2)
52AC_SUBST(SESSIONERVICE_CFLAGS)50AC_SUBST(SESSIONERVICE_CFLAGS)
53AC_SUBST(SESSIONERVICE_LIBS)51AC_SUBST(SESSIONERVICE_LIBS)
5452
@@ -60,14 +58,15 @@
60###########################58###########################
6159
62AC_ARG_ENABLE([gtklogouthelper],60AC_ARG_ENABLE([gtklogouthelper],
63 AS_HELP_STRING([--enable-gtklogouthelper], [enable GTK Logout Helper]),,61 [AS_HELP_STRING([--enable-gtklogouthelper], [enable GTK Logout Helper])],
64 enable_gtklogouthelper=auto)62 [],
63 [enable_gtklogouthelper=auto])
6564
66if test x"$enable_gtklogouthelper" != x"no" ; then65if test x"$enable_gtklogouthelper" != x"no" ; then
67 PKG_CHECK_MODULES(GTKLOGOUTHELPER, gtk+-3.0 >= $GTK_REQUIRED_VERSION66 PKG_CHECK_MODULES([GTKLOGOUTHELPER],
68 polkit-gobject-1 >= $POLKIT_REQUIRED_VERSION,67 [gtk+-3.0 >= $GTK_REQUIRED_VERSION],
69 [have_gtklogouthelper=yes],68 [have_gtklogouthelper=yes],
70 [have_gtklogouthelper=no])69 [have_gtklogouthelper=no])
71 if test x${have_gtklogouthelper} = xyes; then70 if test x${have_gtklogouthelper} = xyes; then
72 AC_DEFINE(HAVE_GTKLOGOUTHELPER, 1, [Define to 1 to enable GTK Logout Helper])71 AC_DEFINE(HAVE_GTKLOGOUTHELPER, 1, [Define to 1 to enable GTK Logout Helper])
73 fi72 fi
7473
=== modified file 'debian/changelog'
--- debian/changelog 2012-11-30 11:03:09 +0000
+++ debian/changelog 2012-11-30 16:35:26 +0000
@@ -11,6 +11,9 @@
11 - Add libgtest-dev, libdbustest1-dev, dbus-test-runner to Build-Depends.11 - Add libgtest-dev, libdbustest1-dev, dbus-test-runner to Build-Depends.
12 - Adjust style to be consistent and use trailing commas in lists. 12 - Adjust style to be consistent and use trailing commas in lists.
13 - Update Vcs-Bzr and Vcs-Browser fields and add notice for uploaders.13 - Update Vcs-Bzr and Vcs-Browser fields and add notice for uploaders.
14 - Remove libpackagekit-glib2-dev and libpolkit-gobject-1-dev
15 from Build-Depends. (LP: #1085100)
16 - Remove packagekit from Recommends
14 * Automatic snapshot from revision 373 (bootstrap):17 * Automatic snapshot from revision 373 (bootstrap):
15 - Check to make sure that create_display_proxy() succeeded before using the18 - Check to make sure that create_display_proxy() succeeded before using the
16 proxy pointer that gets returned. (LP: #1078119)19 proxy pointer that gets returned. (LP: #1078119)
1720
=== modified file 'debian/control'
--- debian/control 2012-11-30 11:03:09 +0000
+++ debian/control 2012-11-30 16:35:26 +0000
@@ -16,8 +16,6 @@
16 libindicator3-dev (>= 0.3.90),16 libindicator3-dev (>= 0.3.90),
17 libdbusmenu-glib-dev (>= 0.5.90),17 libdbusmenu-glib-dev (>= 0.5.90),
18 libdbusmenu-gtk3-dev (>= 0.5.90),18 libdbusmenu-gtk3-dev (>= 0.5.90),
19 libpackagekit-glib2-dev,
20 libpolkit-gobject-1-dev,
21Standards-Version: 3.9.319Standards-Version: 3.9.3
22Homepage: https://launchpad.net/indicator-session20Homepage: https://launchpad.net/indicator-session
23# If you aren't a member of ~indicator-applet-developers but need to upload21# If you aren't a member of ~indicator-applet-developers but need to upload
@@ -33,7 +31,6 @@
33 upower,31 upower,
34 gnome-settings-daemon,32 gnome-settings-daemon,
35Recommends: indicator-applet (>= 0.2) | indicator-renderer, 33Recommends: indicator-applet (>= 0.2) | indicator-renderer,
36 packagekit-system-interface | packagekit,
37Suggests: lightdm34Suggests: lightdm
38Description: indicator showing session management, status and user switching35Description: indicator showing session management, status and user switching
39 This indicator is designed to be placed on the right side of a panel and36 This indicator is designed to be placed on the right side of a panel and

Subscribers

People subscribed via source and target branches