Merge lp:~charlesk/indicator-application/nogtk2 into lp:indicator-application/12.10

Proposed by Charles Kerr
Status: Merged
Approved by: Lars Karlitski
Approved revision: 233
Merged at revision: 233
Proposed branch: lp:~charlesk/indicator-application/nogtk2
Merge into: lp:indicator-application/12.10
Diff against target: 78 lines (+8/-39)
2 files modified
configure.ac (+8/-33)
src/Makefile.am (+0/-6)
To merge this branch: bzr merge lp:~charlesk/indicator-application/nogtk2
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
jenkins continuous-integration Pending
Review via email: mp+105003@code.launchpad.net

Commit message

remove gtk2 support

Description of the change

remove gtk2 support

To post a comment you must log in.
Revision history for this message
Lars Karlitski (larsu) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure.ac'
--- configure.ac 2012-04-11 17:15:43 +0000
+++ configure.ac 2012-05-07 23:45:24 +0000
@@ -29,8 +29,7 @@
29# Dependencies29# Dependencies
30###########################30###########################
3131
32GTK_REQUIRED_VERSION=2.1832GTK_REQUIRED_VERSION=3.0.0
33GTK3_REQUIRED_VERSION=2.91
34GIO_REQUIRED_VERSION=2.2633GIO_REQUIRED_VERSION=2.26
35INDICATOR_REQUIRED_VERSION=0.3.534INDICATOR_REQUIRED_VERSION=0.3.5
36DBUSMENUGTK_REQUIRED_VERSION=0.5.9035DBUSMENUGTK_REQUIRED_VERSION=0.5.90
@@ -39,36 +38,13 @@
3938
40LIBAPPINDICATOR_REQUIRED_VERSION=0.2.939LIBAPPINDICATOR_REQUIRED_VERSION=0.2.9
4140
42AC_ARG_WITH([gtk],41PKG_CHECK_MODULES(INDICATOR, gtk+-3.0 >= $GTK_REQUIRED_VERSION
43 [AS_HELP_STRING([--with-gtk],42 gio-2.0 >= $GIO_REQUIRED_VERSION
44 [Which version of gtk to use @<:@default=3@:>@])],43 indicator3-0.4 >= $INDICATOR_REQUIRED_VERSION
45 [],44 json-glib-1.0 >= $JSON_GLIB_REQUIRED_VERSION
46 [with_gtk=3])45 dbus-glib-1 >= $DBUS_GLIB_REQUIRED_VERSION
47AS_IF([test "x$with_gtk" = x3],46 dbusmenu-gtk3-0.4 >= $DBUSMENUGTK_REQUIRED_VERSION)
48 [PKG_CHECK_MODULES(INDICATOR, gtk+-3.0 >= $GTK3_REQUIRED_VERSION47PKG_CHECK_MODULES(APPINDICATOR, appindicator3-0.1 >= $LIBAPPINDICATOR_REQUIRED_VERSION)
49 gio-2.0 >= $GIO_REQUIRED_VERSION
50 indicator3-0.4 >= $INDICATOR_REQUIRED_VERSION
51 json-glib-1.0 >= $JSON_GLIB_REQUIRED_VERSION
52 dbus-glib-1 >= $DBUS_GLIB_REQUIRED_VERSION
53 dbusmenu-gtk3-0.4 >= $DBUSMENUGTK_REQUIRED_VERSION)
54
55 PKG_CHECK_MODULES(APPINDICATOR, appindicator3-0.1 >= $LIBAPPINDICATOR_REQUIRED_VERSION)
56
57 AC_DEFINE(HAVE_GTK3, 1, [whether gtk3 is available])
58 ],
59 [test "x$with_gtk" = x2],
60 [PKG_CHECK_MODULES(INDICATOR, gtk+-2.0 >= $GTK_REQUIRED_VERSION
61 gio-2.0 >= $GIO_REQUIRED_VERSION
62 indicator-0.4 >= $INDICATOR_REQUIRED_VERSION
63 json-glib-1.0 >= $JSON_GLIB_REQUIRED_VERSION
64 dbus-glib-1 >= $DBUS_GLIB_REQUIRED_VERSION
65 dbusmenu-gtk-0.4 >= $DBUSMENUGTK_REQUIRED_VERSION)
66
67 PKG_CHECK_MODULES(APPINDICATOR, appindicator-0.1 >= $LIBAPPINDICATOR_REQUIRED_VERSION)
68 ],
69 [AC_MSG_FAILURE([Value for --with-gtk was neither 2 nor 3])]
70)
71AM_CONDITIONAL(USE_GTK3, [test "x$with_gtk" = x3])
7248
73###########################49###########################
74# gcov coverage reporting50# gcov coverage reporting
@@ -142,6 +118,5 @@
142118
143 Prefix: $prefix119 Prefix: $prefix
144 Indicator Dir: $INDICATORDIR120 Indicator Dir: $INDICATORDIR
145 GTK+ Version: $with_gtk
146 gcov: $use_gcov121 gcov: $use_gcov
147])122])
148123
=== modified file 'src/Makefile.am'
--- src/Makefile.am 2011-12-06 21:49:39 +0000
+++ src/Makefile.am 2012-05-07 23:45:24 +0000
@@ -1,9 +1,3 @@
1if USE_GTK3
2VER=3
3else
4VER=
5endif
6
7CLEANFILES =1CLEANFILES =
8DISTCLEANFILES =2DISTCLEANFILES =
9BUILT_SOURCES =3BUILT_SOURCES =

Subscribers

People subscribed via source and target branches