Merge lp:~charlesk/gnome-control-center/make-new-panel into lp:~cjcurran/gnome-control-center/make-new-panel

Proposed by Charles Kerr
Status: Needs review
Proposed branch: lp:~charlesk/gnome-control-center/make-new-panel
Merge into: lp:~cjcurran/gnome-control-center/make-new-panel
Diff against target: 51 lines (+17/-2)
1 file modified
panels/sound-nua/gvc-mixer-dialog.c (+17/-2)
To merge this branch: bzr merge lp:~charlesk/gnome-control-center/make-new-panel
Reviewer Review Type Date Requested Status
Conor Curran Pending
Review via email: mp+91475@code.launchpad.net

Description of the change

r225 is straightforward code that adds a paragraph for Bug #829648

https://wiki.ubuntu.com/SoundMenu#presence

To post a comment you must log in.
226. By Charles Kerr

Move the visibility checkbox to the bottom of the page (underneath the volume slider) as per mpt's request

Unmerged revisions

226. By Charles Kerr

Move the visibility checkbox to the bottom of the page (underneath the volume slider) as per mpt's request

225. By Charles Kerr

Add indicator visibility checkbox for Bug #829648

https://wiki.ubuntu.com/SoundMenu#presence

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'panels/sound-nua/gvc-mixer-dialog.c'
--- panels/sound-nua/gvc-mixer-dialog.c 2012-02-03 17:15:47 +0000
+++ panels/sound-nua/gvc-mixer-dialog.c 2012-02-03 19:09:34 +0000
@@ -83,9 +83,10 @@
83 GtkWidget *click_feedback_button;83 GtkWidget *click_feedback_button;
84 GtkWidget *audible_bell_button;84 GtkWidget *audible_bell_button;
85 GtkSizeGroup *size_group;85 GtkSizeGroup *size_group;
86 GtkWidget *selected_output_label;86 GtkWidget *selected_output_label;
87 GtkWidget *selected_input_label;87 GtkWidget *selected_input_label;
88 GtkWidget *test_output_button;88 GtkWidget *test_output_button;
89 GSettings *indicator_settings;
8990
90 gdouble last_input_peak;91 gdouble last_input_peak;
91 guint num_apps;92 guint num_apps;
@@ -1666,6 +1667,7 @@
1666{1667{
1667 GObject *object;1668 GObject *object;
1668 GvcMixerDialog *self;1669 GvcMixerDialog *self;
1670 GtkWidget *w;
1669 GtkWidget *main_vbox;1671 GtkWidget *main_vbox;
1670 GtkWidget *label;1672 GtkWidget *label;
1671 GtkWidget *alignment;1673 GtkWidget *alignment;
@@ -1983,6 +1985,17 @@
1983 gtk_box_pack_start (GTK_BOX (self->priv->output_stream_box),1985 gtk_box_pack_start (GTK_BOX (self->priv->output_stream_box),
1984 self->priv->output_bar, TRUE, FALSE, 12);1986 self->priv->output_bar, TRUE, FALSE, 12);
19851987
1988 /* Indicator visibility toggle */
1989 w = gtk_check_button_new_with_mnemonic(_( "_Show sound volume in the menu bar"));
1990 alignment = gtk_alignment_new (0, 0, 1, 1);
1991 gtk_alignment_set_padding (GTK_ALIGNMENT (alignment), 3, 3, 5, 5);
1992 gtk_container_add (GTK_CONTAINER (alignment), w);
1993 self->priv->indicator_settings = g_settings_new ("com.canonical.indicator.sound");
1994 g_settings_bind (self->priv->indicator_settings, "visible", w, "active", G_SETTINGS_BIND_DEFAULT);
1995 gtk_box_pack_start (GTK_BOX (main_vbox),
1996 alignment,
1997 FALSE, FALSE, 0);
1998
1986 gtk_widget_show_all (main_vbox);1999 gtk_widget_show_all (main_vbox);
19872000
1988 g_signal_connect (self->priv->mixer_control,2001 g_signal_connect (self->priv->mixer_control,
@@ -2048,6 +2061,8 @@
2048{2061{
2049 GvcMixerDialog *dialog = GVC_MIXER_DIALOG (object);2062 GvcMixerDialog *dialog = GVC_MIXER_DIALOG (object);
20502063
2064 g_clear_object (&dialog->priv->indicator_settings);
2065
2051 if (dialog->priv->mixer_control != NULL) {2066 if (dialog->priv->mixer_control != NULL) {
2052 g_signal_handlers_disconnect_by_func (dialog->priv->mixer_control,2067 g_signal_handlers_disconnect_by_func (dialog->priv->mixer_control,
2053 on_control_output_added,2068 on_control_output_added,

Subscribers

People subscribed via source and target branches

to all changes: