Merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-hostname-bug into lp:ubuntu-filemanager-app
Proposed by
Carlos Jose Mazieri
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Arto Jalkanen | ||||
Approved revision: | 499 | ||||
Merged at revision: | 500 | ||||
Proposed branch: | lp:~carlos-mazieri/ubuntu-filemanager-app/samba-hostname-bug | ||||
Merge into: | lp:ubuntu-filemanager-app | ||||
Diff against target: |
39 lines (+13/-7) 1 file modified
src/plugin/folderlistmodel/smb/qsambaclient/src/smbutil.cpp (+13/-7) |
||||
To merge this branch: | bzr merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-hostname-bug | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Arto Jalkanen | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+276932@code.launchpad.net |
Commit message
Fixed a bug #1508504 related to get the Samba hostname.
It used to get the description instead of the name.
For some cases the name is the first word in the description, so it worked in some cases.
Description of the change
Fixed a bug #1508504 related to get the Samba hostname.
It used to get the description instead of the name.
For some cases the name is the first word in the description, so it worked in some cases.
To post a comment you must log in.
PASSED: Continuous integration, rev:499 /core-apps- jenkins. ubuntu. com/job/ filemanager- app-ci/ 31/ /core-apps- jenkins. ubuntu. com/job/ generic- update- mp/114/ console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /core-apps- jenkins. ubuntu. com/job/ filemanager- app-ci/ 31/rebuild
https:/