Merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-05 into lp:ubuntu-filemanager-app
Proposed by
Carlos Jose Mazieri
Status: | Merged |
---|---|
Approved by: | Arto Jalkanen |
Approved revision: | 436 |
Merged at revision: | 440 |
Proposed branch: | lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-05 |
Merge into: | lp:ubuntu-filemanager-app |
Prerequisite: | lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-04 |
Diff against target: |
134 lines (+59/-14) 3 files modified
src/plugin/folderlistmodel/trash/qtrashdir.cpp (+2/-2) src/plugin/folderlistmodel/trash/qtrashutilinfo.cpp (+27/-10) src/plugin/folderlistmodel/trash/trashiteminfo.cpp (+30/-2) |
To merge this branch: | bzr merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-05 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Arto Jalkanen | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+265196@code.launchpad.net |
Commit message
Improved TrashItemInfo creator to identify which is the Trash Root part
Description of the change
Actions on Trash were performed using Qt QFileInfo object, the TrashItemInfo class was improved to be used instead.
To post a comment you must log in.
PASSED: Continuous integration, rev:436 91.189. 93.70:8080/ job/ubuntu- filemanager- app-ci/ 512/ 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 3096 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 3096/artifact/ work/output/ *zip*/output. zip 91.189. 93.70:8080/ job/ubuntu- filemanager- app-utopic- amd64-ci/ 228 91.189. 93.70:8080/ job/ubuntu- filemanager- app-vivid- amd64-ci/ 134
http://
Executed test runs:
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- filemanager- app-ci/ 512/rebuild
http://