Merge lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm into lp:~partner-contact-core-editors/partner-contact-management/7.0

[Vincent Renaville@camptocamp]

This add the functionality :

- When a email is received , it will create the lead + the partner (Firstname and Lastname is discovered based on email address).

- The partner created is set as follower of the lead.

[lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm]

32. By Vincent Renaville@camptocamp on 2014-04-02

[FIX] author

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Hello,

Thanks for this proposal. Here are few things to fix.

In _compute_name_custom why not using the same way to construct the full name?

http://bazaar.launchpad.net/~partner-contact-core-editors/partner-contact-management/7.0/view/head:/partner_firstname/partner.py#L43

ir.model.data is defined twice.

128 + obj_data = self.pool.get('ir.model.data')
129 + ## We search category for this contact :
130 + obj_data = self.pool.get('ir.model.data')
131 + ##

By the way you can use list index

self.pool['ir.model.data']

crm.py|111 col 1| F841 local variable 'create_context' is assigned to but never used

ll.133 - 139 missing context in search and browse

review: Needs Fixing (code review, no test)

[lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm]

33. By Vincent Renaville@camptocamp on 2014-04-02

[FIX] add missing context in browse and search, use the same contract_name function as specified in partner_firstname, remove un used variable

[Vincent Renaville@camptocamp (vrenaville-c2c)]

Thanks Yannick for your review,

I have fixed according to your review at rev 33.

For the _compute_name_custom , I think I have used an old version of the version present partner_firstname module.
I have update it as well.

Vincent

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Could you provide some docstring and exemples of what will do _common_lead_partner ?

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

I fail to see how the addon name "crm_firstname" relates to the described functionality. Please copy the description provided in the MP in __openerp__.py : this is what people looking at the module will see.

__openerp__.py : s/demo_xml/demo/ and then remove it as it is empty

+ 'email': tools.email_split(lead.email_from) and tools.email_split(lead.email_from)[0] or False, => use the val if cond else default construct if you absolutely want this on a single line. Same thing for the other fields in that dict.

you forgot to add the tests and to link them in __openerp__.py :-)

review: Needs Fixing (code review, no test)

[lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm]

34. By Vincent Renaville@camptocamp on 2014-04-02

[FIX] improve module name and description + remove unused section

35. By Vincent Renaville@camptocamp on 2014-04-02

[FIX] impve code readibility

[Vincent Renaville@camptocamp (vrenaville-c2c)]

Hello,

Thanks for the review

I have improve code visibility according to your review and the module description.

I have test manually with different kind of email.

Thanks for the review

Vincent

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

OK.

I'd still like to see tests in the near future for this one.

review: Approve (code review, no test)

[lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm]

36. By Vincent Renaville@camptocamp on 2014-04-04

[FIX] typo

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

review: Approve (code review, no test)

[lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm]

37. By Vincent Renaville@camptocamp on 2014-04-30

[FIX] Cleaning of unused field

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

crm_firstname/__openerp__.py:22:1: O603 Manifest "license" key is missing
crm_firstname/__openerp__.py:35:19: E231 missing whitespace after ','
crm_firstname/__openerp__.py:37:11: E126 continuation line over-indented for hanging indent
crm_firstname/__openerp__.py:39:11: E123 closing bracket does not match indentation of opening bracket's line
crm_firstname/__openerp__.py:41:2: O600 Warning unknown Manifest key ('active') <-- deprecated
crm_firstname/crm.py:5:30: W291 trailing whitespace
crm_firstname/crm.py:35:30: E127 continuation line over-indented for visual indent
crm_firstname/crm.py:41:1: W293 blank line contains whitespace
crm_firstname/crm.py:43:17: E126 continuation line over-indented for hanging indent
crm_firstname/crm.py:48:77: W291 trailing whitespace
crm_firstname/crm.py:49:17: E123 closing bracket does not match indentation of opening bracket's line
crm_firstname/crm.py:58:9: E265 block comment should start with '# '
crm_firstname/crm.py:58:11: W291 trailing whitespace
crm_firstname/crm.py:67:80: E231 missing whitespace after ','
crm_firstname/crm.py:70:1: W293 blank line contains whitespace
crm_firstname/crm.py:77:17: E126 continuation line over-indented for hanging indent
crm_firstname/crm.py:91:26: E231 missing whitespace after ':'
crm_firstname/crm.py:113:17: E265 block comment should start with '#

review: Needs Fixing (pep8)

[Lorenzo Battistini (elbati)]

This project is now hosted on https://github.com/OCA/partner-contact. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Unmerged revisions

37. By Vincent Renaville@camptocamp on 2014-04-30

[FIX] Cleaning of unused field

36. By Vincent Renaville@camptocamp on 2014-04-04

[FIX] typo

35. By Vincent Renaville@camptocamp on 2014-04-02

[FIX] impve code readibility

34. By Vincent Renaville@camptocamp on 2014-04-02

[FIX] improve module name and description + remove unused section

33. By Vincent Renaville@camptocamp on 2014-04-02

[FIX] add missing context in browse and search, use the same contract_name function as specified in partner_firstname, remove un used variable

32. By Vincent Renaville@camptocamp on 2014-04-02

[FIX] author

31. By Vincent Renaville@camptocamp on 2014-04-01

[IMP] pep8 + translation

30. By Vincent Renaville@camptocamp on 2014-04-01

[ADD] Follower + add email in name in case no contact found

29. By Vincent Renaville@camptocamp on 2014-02-03

[FIX] change osv to orm

28. By Vincent Renaville@camptocamp on 2013-11-01

[FIX] remove pdb

=== added directory 'crm_firstname'
=== added file 'crm_firstname/__init__.py'
--- crm_firstname/__init__.py	1970-01-01 00:00:00 +0000
+++ crm_firstname/__init__.py	2014-04-30 07:31:32 +0000
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#   Copyright (c) 2013 Camptocamp SA (http://www.camptocamp.com)
+#   @author Vincent Renaville
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+from . import crm
 
=== added file 'crm_firstname/__openerp__.py'
--- crm_firstname/__openerp__.py	1970-01-01 00:00:00 +0000
+++ crm_firstname/__openerp__.py	2014-04-30 07:31:32 +0000
@@ -0,0 +1,42 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#   Copyright (c) 2013 Camptocamp SA (http://www.camptocamp.com)
+#   @author Vincent Renaville
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{'name': 'CRM automatic linked partner creation (with firstname and lastname)',
+ 'version': '1.0.0',
+ 'category': 'other',
+ 'description': """WARNING : This module depend on partner_firstname please check module description before installing this module.
+
+This module add the following functionnalities :
+- When a email is received , it will create the lead + the partner (Firstname and Lastname is discovered based on email address).
+- It improve the view of a lead/opportunies to add the firstname and the lastname
+
+- The partner created is set as follower of the lead.
+""",
+ 'author': 'Camptocamp',
+ 'website': 'http://www.camptocamp.com',
+ 'depends': ['crm','partner_firstname'],
+ 'data': [
+          'data.xml',
+          'crm_view.xml'
+          ],
+ 'installable': True,
+ 'active': False,
+ }
 
=== added file 'crm_firstname/crm.py'
--- crm_firstname/crm.py	1970-01-01 00:00:00 +0000
+++ crm_firstname/crm.py	2014-04-30 07:31:32 +0000
@@ -0,0 +1,196 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#   Copyright (c) 2014 Camptocamp SA (http://www.camptocamp.com)
+#   @author Vincent Renaville 
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+from openerp.osv import orm, fields
+from openerp import tools
+from openerp.tools.translate import _
+
+
+class CrmLead(orm.Model):
+
+    _inherit = "crm.lead"
+
+    def _compute_contact_name_custom(self, cursor,
+                                     uid, ids,
+                                     fname, arg, context=None):
+        res = {}
+        leads = self.read(cursor, uid, ids,
+                             ['firstname', 'lastname'], context=context)
+        for rec in leads:
+            names = (rec['lastname'], rec['firstname'])
+            fullname = " ".join([s for s in names if s])
+            res[rec['id']] = fullname
+        return res
+    
+    _columns = {
+                'firstname': fields.char("Firstname"),
+                'lastname': fields.char("Lastname"),
+                'contact_name': fields.function(_compute_contact_name_custom,
+                                                string="Contact Name",
+                                                type="char", store=True,
+                                                select=True, readonly=True), 
+                }
+
+    def _lead_create_contact_with_firstname_lastname(self, cr, uid,
+                                                     lead, lastname, firstname,
+                                                     is_company,
+                                                     parent_id=False,
+                                                     context=None):
+        partner = self.pool.get('res.partner')
+        obj_data = self.pool.get('ir.model.data')
+        ## 
+        category_record = None
+        category_record_ids = obj_data.search(cr, uid,
+                                              [('name',
+                                                '=',
+                                                'res_partner_category_automatic_from_email'),
+                                               ('model', '=', 'res.partner.category')],
+                                              context=context)
+        if category_record_ids:
+            category_record_part = obj_data.browse(cr, uid, category_record_ids,context=context)
+            if category_record_part:
+                category_record = [(6, 0, [category_record_part[0].res_id])]
+                
+        email_part = tools.email_split(lead.email_from)
+        if email_part:
+            email = email_part[0]
+        else:
+            email = None
+        vals = {
+                'lastname': lastname,
+                'firstname': firstname,
+                'user_id': lead.user_id.id,
+                'comment': lead.description,
+                'parent_id': parent_id,
+                'phone': lead.phone,
+                'mobile': lead.mobile,
+                'email': email,
+                'fax': lead.fax,
+                'function': lead.function,
+                'street': lead.street,
+                'street2': lead.street2,
+                'zip': lead.zip,
+                'city': lead.city,
+                'opt_out':True,
+                'category_id': category_record,
+                'notification_email_send': 'comment',
+                'country_id': lead.country_id and lead.country_id.id or False,
+                'is_company': is_company,
+                'type': 'contact'
+        }
+        partner_id = partner.create(cr, uid, vals, context=context)
+        if partner_id:
+            follower_obj = self.pool.get('mail.followers')
+            val_follow = {'res_model': 'crm.lead',
+                          'res_id': lead.id,
+                          'partner_id': partner_id
+                          }
+            follower_obj.create(cr, uid, val_follow, context=context)
+        return partner_id
+
+    def create(self, cr, uid, vals, context=None):
+        lead_id = super(CrmLead, self).create(cr, uid, vals, context=context)
+        if lead_id:
+            lead = self.browse(cr, uid, lead_id)
+            if not vals['partner_id']:
+                ## No partner created
+                partner_id = self._common_lead_partner(cr, uid, lead, context)
+                if partner_id:
+                    self.write(cr, uid, [lead.id], {'partner_id': partner_id})
+
+        return lead_id
+
+    def _common_lead_partner(self, cr, uid, lead, context=None):
+        partner_id = False
+        partner_obj = self.pool.get('res.partner')
+        if lead.partner_name and lead.contact_name:
+            partner_id = self._lead_create_contact_with_firstname_lastname(cr, uid,
+                                                                           lead, lead.partner_name,
+                                                                           False, True, context=context)
+            partner_id = self._lead_create_contact_with_firstname_lastname(cr, uid,
+                                                                           lead, lead.lastname,
+                                                                           lead.firstname, False,
+                                                                           partner_id, context=context)
+        elif lead.partner_name and not lead.contact_name:
+            partner_id = self._lead_create_contact_with_firstname_lastname(cr, uid,
+                                                                           lead, lead.partner_name,
+                                                                           False, True, context=context)
+        elif not lead.partner_name and lead.contact_name:
+            partner_id = self._lead_create_contact_with_firstname_lastname(cr, uid,
+                                                                           lead, lead.lastname,
+                                                                           lead.firstname, False, context=context)
+        elif lead.email_from and partner_obj._parse_partner_name(lead.email_from,
+                                                                 context=context)[0]:
+            contact_dict = partner_obj._parse_partner_firstname_lastname(lead.email_from,
+                                                                         context=context)
+            partner_id = self._lead_create_contact_with_firstname_lastname(cr, uid, lead,
+                                                                           contact_dict['firstname'],
+                                                                           contact_dict['lastname'],
+                                                                           False, context=context)
+        elif lead.email_from:
+            contact_dict = partner_obj._parse_partner_firstname_lastname(lead.email_from,
+                                                                         context=context)
+            partner_id = self._lead_create_contact_with_firstname_lastname(cr, uid, lead,
+                                                                           contact_dict['firstname'],
+                                                                           contact_dict['lastname'],
+                                                                           False, context=context)
+        return partner_id
+
+    def _create_lead_partner(self, cr, uid, lead, context=None):
+        partner_id = False
+        partner_id = self._common_lead_partner(cr, uid, lead, context)
+        if not partner_id:
+            raise orm.except_orm(
+                _('Warning!'),
+                _('No customer name defined. Please fill one of the following fields: Company Name, Contact Name or Email ("Name <email@address>")')
+            )
+        return partner_id
+
+
+class ResPartner(orm.Model):
+
+    _inherit = "res.partner"
+
+    def _parse_partner_firstname_lastname(self, text, context=None):
+        """ Supported syntax:
+            - 'Raoul <[e-mail]>': will find name and email address
+            - otherwise: default, everything is set as the name """
+        firstname_lastname = {'firstname': '',
+                              'lastname': '',
+                              }
+        emails = tools.email_split(text)
+        if emails:
+            email = emails[0]
+            name = text[:text.index(email)].replace('"', '').replace('<', '').strip()
+            if name:
+                split_name = name.split(' ', 1)
+                if len(split_name) == 2:
+                    firstname_lastname['firstname'] = split_name[0]
+                    firstname_lastname['lastname'] = split_name[1]
+                else:
+                    firstname_lastname['firstname'] = split_name[0]
+                    firstname_lastname['lastname'] = ''
+            else:
+                firstname_lastname['firstname'] = email
+                firstname_lastname['lastname'] = ''
+        else:
+                firstname_lastname['firstname'] = text
+                firstname_lastname['lastname'] = ''
+        return firstname_lastname
 
=== added file 'crm_firstname/crm_view.xml'
--- crm_firstname/crm_view.xml	1970-01-01 00:00:00 +0000
+++ crm_firstname/crm_view.xml	2014-04-30 07:31:32 +0000
@@ -0,0 +1,20 @@
+<openerp>
+  <data>
+    <record id="crm_case_form_view_leads_firstname_lastname" model="ir.ui.view">
+      <field name="name">CRM - Leads Form Lastname Firstname</field>
+      <field name="model">crm.lead</field>
+      <field name="inherit_id" ref="crm.crm_case_form_view_leads"/>
+      <field name="arch" type="xml">
+        <xpath expr="//field[@name='title']" position="after">
+        	<div>
+			<label for="firstname" string="Firstname"/>
+                <field name="firstname"/>
+			<label for="lastname" string="Lastname"/>
+                <field name="lastname"/>
+            </div>
+        </xpath>  
+      </field>
+    </record>
+  
+  </data>
+</openerp>
 
=== added file 'crm_firstname/data.xml'
--- crm_firstname/data.xml	1970-01-01 00:00:00 +0000
+++ crm_firstname/data.xml	2014-04-30 07:31:32 +0000
@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data noupdate="1">
+        <!--
+        Resource: res.partner.category
+        -->
+        <record id="res_partner_category_automatic_from_email" model="res.partner.category">
+            <field name="name">Automatic Contact</field>
+        </record>
+    </data>
+</openerp>
+
 
=== added directory 'crm_firstname/i18n'
=== added file 'crm_firstname/i18n/crm_firstname.pot'
--- crm_firstname/i18n/crm_firstname.pot	1970-01-01 00:00:00 +0000
+++ crm_firstname/i18n/crm_firstname.pot	2014-04-30 07:31:32 +0000
@@ -0,0 +1,39 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* crm_firstname
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-04-01 15:13+0000\n"
+"PO-Revision-Date: 2014-04-01 15:13+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: crm_firstname
+#: model:res.partner.category,name:crm_firstname.res_partner_category_automatic_from_email
+msgid "Automatic Contact"
+msgstr ""
+
+#. module: crm_firstname
+#: view:crm.lead:0
+msgid "Firstname"
+msgstr ""
+
+#. module: crm_firstname
+#: view:crm.lead:0
+msgid "Lastname"
+msgstr ""
+
+#. module: crm_firstname
+#: code:_description:0
+#, python-format
+msgid "Lead/Opportunity"
+msgstr ""
+
+
 
=== added file 'crm_firstname/i18n/fr.po'
--- crm_firstname/i18n/fr.po	1970-01-01 00:00:00 +0000
+++ crm_firstname/i18n/fr.po	2014-04-30 07:31:32 +0000
@@ -0,0 +1,39 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* crm_firstname
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-04-01 15:13+0000\n"
+"PO-Revision-Date: 2014-04-01 15:13+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: crm_firstname
+#: model:res.partner.category,name:crm_firstname.res_partner_category_automatic_from_email
+msgid "Automatic Contact"
+msgstr "Contact automatique"
+
+#. module: crm_firstname
+#: view:crm.lead:0
+msgid "Firstname"
+msgstr "Prénom"
+
+#. module: crm_firstname
+#: view:crm.lead:0
+msgid "Lastname"
+msgstr "Nom"
+
+#. module: crm_firstname
+#: code:_description:0
+#, python-format
+msgid "Lead/Opportunity"
+msgstr "Piste/Opportunité"
+
+