Merge lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into lp:~openerprma/openerp-rma/7.0
Proposed by
Romain Deheele - Camptocamp
Status: | Merged |
---|---|
Approved by: | Leonardo Pistone |
Approved revision: | 81 |
Merged at revision: | 80 |
Proposed branch: | lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde |
Merge into: | lp:~openerprma/openerp-rma/7.0 |
Diff against target: |
33 lines (+12/-0) 2 files modified
crm_claim_rma/crm_claim_rma.py (+9/-0) crm_claim_rma/wizard/claim_make_picking.py (+3/-0) |
To merge this branch: | bzr merge lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lionel Sausin - Initiatives/Numérigraphe (community) | code review, not test | Approve | |
Leonardo Pistone | code review | Approve | |
Joël Grand-Guillaume @ camptocamp | code review, no tests | Approve | |
Benoit Guillot - http://www.akretion.com | Approve | ||
Review via email: mp+218666@code.launchpad.net |
Description of the change
Hello,
It adds a _auto_set_warranty function.
For each claim line, if the user has not pressed himself on 'calculate warranty state', it sets warranties automatically for him.
Regards,
Romain
To post a comment you must log in.
Hello Romain,
I have tested it, it works fine.
Thank you!
One thing, we can maybe put the method _auto_set_ warranty( ) in the model of claim lines and don't use it as a private method ? warranty( self, cr, uid, ids, context):
=> def auto_set_
So it can be call from somthing else (a button for instance).
I'm not sure it is useful but I share my thought :)
What do you think ?