Merge lp:~camptocamp/magentoerpconnect/magentoerpconnect_generic_bug_497216 into lp:~magentoerpconnect-core-editors/magentoerpconnect/magentoerpconnect_generic

[Nicolas Bessi - Camptocamp]

Fix of bug 497216

OK Live and learn, the bug fix is really small, but I had to understand the whole process in order to fix it.

Thanks to everybody for the help.
I hope this one will be good.

Regards Nicolas

[Sharoon Thomas http://openlabs.co.in (sharoonthomas)]

The fix looks trivial

(I have not tested it though its the same fix i suggested.)

I think we should wait for two more approvals (Functional & Technical) before merging.

I assume that Your merge proposal can be considered the first functional approval.
So requesting one more approvals before we merge this.

review: Approve

[Sharoon Thomas http://openlabs.co.in (sharoonthomas)]

I have tested this both functionally & technically.

Hence i approve this merge.

Unmerged revisions

296. By Nicolas Bessi - Camptocamp on 2010-04-01

Fix of bug 497216

=== modified file 'magerp_core.py'
--- magerp_core.py	2010-03-26 18:17:43 +0000
+++ magerp_core.py	2010-04-01 08:17:16 +0000
@@ -84,7 +84,7 @@
                 #Get all attribute set ids to get all attributes in one go
                 all_attr_set_ids = self.pool.get('magerp.product_attribute_set').get_all_mage_ids(cr, uid, [], inst.id)
                 #Call magento for all attributes
-                mage_inp = attr_conn.call('ol_catalog_product_attribute.list', all_attr_set_ids)             #Get the tree
+                mage_inp = attr_conn.call('ol_catalog_product_attribute.list', [all_attr_set_ids])             #Get the tree
                 #self.pool.get('magerp.product_attributes').sync_import(cr, uid, mage_inp, inst.id, DEBUG) #Last argument is extra mage2oe filter as same attribute ids
                 self.pool.get('magerp.product_attributes').ext_import(cr, uid, mage_inp, inst.id, defaults={'referential_id':inst.id}, context={'referential_id':inst.id})
                 #Relate attribute sets & attributes