Merge lp:~camptocamp/magentoerpconnect/import-partners-fix-magento-request-2013-02-26 into lp:magentoerpconnect/oerp6.1-oldstable

[Yannick Vaucher @ Camptocamp]

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

LGTM

+1 for pun.

review: Approve (code review, no test)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Alexandre noticed that the `updated_at` field is populated with the creation datetime when a record is created, so you can just always rely on this field and avoid two calls.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

review: Needs Fixing

[lp:~camptocamp/magentoerpconnect/import-partners-fix-magento-request-2013-02-26]

672. By Yannick Vaucher @ Camptocamp on 2013-02-28

[IMP] magentoerpconnect - in partner import make only one call to search ids on 'updated_at' as this field is set on create in magento

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Seems I'm too used to create_date and write_date of OpenERP.

I removed the filter on 'created_at' but I'm not sure whether I should remove or not the generation of multiple call to simulate OR operator even if not used anymore. Maybe this could be done in the call method itself.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

I think that something not used should be removed.

[lp:~camptocamp/magentoerpconnect/import-partners-fix-magento-request-2013-02-26]

673. By Yannick Vaucher @ Camptocamp on 2013-03-01

[REM] magentoerpconnect - remove the ORiginal way to simulate OR operator

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Corrected, be the LGTM with me

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Sorry that you had to remove your pun ;-)

LGTM

review: Approve (code review, no test)

=== modified file 'magentoerpconnect/sale.py'
--- magentoerpconnect/sale.py	2013-02-14 12:59:51 +0000
+++ magentoerpconnect/sale.py	2013-03-01 12:43:31 +0000
@@ -84,14 +84,10 @@
         """
         filters = []
         if from_date:
-            filters = [
-                    {'created_at': {'gt': from_date}}, # OR
-                    {'updated_at': {'gt': from_date}}
-                    ]
+            filters = [{'updated_at': {'gt': from_date}}]
         if website_id:
             if filters:
-                for f in filters:
-                    f.update(website_id={'eq': website_id})
+                filters[0].update(website_id={'eq': website_id})
             else:
                 filters = [{'website_id': {'eq': website_id}}]