Merge lp:~camptocamp/e-commerce-addons/7.0-sale_automatic_workflow-create_invoice_option into lp:~extra-addons-commiter/e-commerce-addons/7.0
Proposed by
Guewen Baconnier @ Camptocamp
Status: | Merged |
---|---|
Approved by: | Yannick Vaucher @ Camptocamp |
Approved revision: | 288 |
Merged at revision: | 288 |
Proposed branch: | lp:~camptocamp/e-commerce-addons/7.0-sale_automatic_workflow-create_invoice_option |
Merge into: | lp:~extra-addons-commiter/e-commerce-addons/7.0 |
Diff against target: |
150 lines (+55/-24) 5 files modified
sale_automatic_workflow/automatic_workflow_data.xml (+17/-7) sale_automatic_workflow/sale.py (+16/-0) sale_automatic_workflow/sale_workflow.xml (+1/-1) sale_automatic_workflow/sale_workflow_process.py (+19/-14) sale_automatic_workflow/sale_workflow_process_view.xml (+2/-2) |
To merge this branch: | bzr merge lp:~camptocamp/e-commerce-addons/7.0-sale_automatic_workflow-create_invoice_option |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Yannick Vaucher @ Camptocamp | code review, no tests | Approve | |
Sandy Carter (http://www.savoirfairelinux.com) | code review, no test | Approve | |
Review via email: mp+194367@code.launchpad.net |
Description of the change
On the workflows, the 'create_invoice' option is no longer a boolean, but a selection between 'off | on confirmation of sales order | after delivery'. The option is only available when the selected order policy is 'manual'. This replaces the removed 'postpaid' order_policy when we use automatic workflows.
It means that your are allowed to invoice on order after delivery, by choosing the 'On Demand' order policy and 'After Delivery' for the 'Create Invoice' option.
To post a comment you must log in.
Note sure why the default reviewer is "extra- addons- commiter" here. Can someone review, please? Thanks