Merge lp:~camptocamp/anybox.recipe.openerp/1.8-fix_github-nbi into lp:anybox.recipe.openerp/1.8

Proposed by Nicolas Bessi - Camptocamp
Status: Work in progress
Proposed branch: lp:~camptocamp/anybox.recipe.openerp/1.8-fix_github-nbi
Merge into: lp:anybox.recipe.openerp/1.8
Diff against target: 30 lines (+7/-2)
2 files modified
anybox/recipe/openerp/base.py (+4/-1)
anybox/recipe/openerp/server.py (+3/-1)
To merge this branch: bzr merge lp:~camptocamp/anybox.recipe.openerp/1.8-fix_github-nbi
Reviewer Review Type Date Requested Status
Georges Racinet Pending
Review via email: mp+221550@code.launchpad.net

Description of the change

Fix setup.py modification in master of Odoo

This fix depends on https://github.com/odoo/odoo/pull/276

To post a comment you must log in.
Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote :

I need some help to finalize this MP.
I'm not sure of all the places this modification must be done.
There is also a more deep modification to do in order to initialize sooner major_version

536. By Nicolas Bessi - Camptocamp

[FIX] forgotten pdb

Revision history for this message
Georges Racinet (gracinet) wrote :

Another path to solution would be to read the simpler release.py if available and avoid that setup patching that dates back to the days of OpenERP 6.0.

Unmerged revisions

536. By Nicolas Bessi - Camptocamp

[FIX] forgotten pdb

535. By Nicolas Bessi - Camptocamp

[ADD] poc to fix github compatibility some hook must be completed and major_version trouble not fixed

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'anybox/recipe/openerp/base.py'
--- anybox/recipe/openerp/base.py 2014-05-27 12:29:32 +0000
+++ anybox/recipe/openerp/base.py 2014-05-30 14:21:19 +0000
@@ -333,7 +333,10 @@
333 setuptools.setup = new_setup333 setuptools.setup = new_setup
334 distutils.core.setup = new_setup334 distutils.core.setup = new_setup
335 sys.path.insert(0, '.')335 sys.path.insert(0, '.')
336 with open(join(self.openerp_dir, 'setup.py'), 'rb') as f:336 setup_dir = 'setup' # how to get major version here ?
337 if self.major_version >= (8, 0):
338 setup_dir = 'setup'
339 with open(join(self.openerp_dir, setup_dir, 'setup.py'), 'rb') as f:
337 saved_argv = sys.argv340 saved_argv = sys.argv
338 sys.argv = ['setup.py', 'develop']341 sys.argv = ['setup.py', 'develop']
339 try:342 try:
340343
=== modified file 'anybox/recipe/openerp/server.py'
--- anybox/recipe/openerp/server.py 2014-05-29 16:13:23 +0000
+++ anybox/recipe/openerp/server.py 2014-05-30 14:21:19 +0000
@@ -108,7 +108,9 @@
108 if self.major_version >= (6, 1):108 if self.major_version >= (6, 1):
109 openerp_dir = getattr(self, 'openerp_dir', None)109 openerp_dir = getattr(self, 'openerp_dir', None)
110 if openerp_dir is not None: # happens in unit tests110 if openerp_dir is not None: # happens in unit tests
111 self.develop(openerp_dir, setup_has_pil=setup_has_pil)111 if self.major_version >= (8, 0):
112 setup_dir = 'setup'
113 self.develop(join(openerp_dir, setup_dir), setup_has_pil=setup_has_pil)
112 self.requirements.append('openerp')114 self.requirements.append('openerp')
113115
114 if self.with_gunicorn:116 if self.with_gunicorn:

Subscribers

People subscribed via source and target branches

to all changes: