Merge lp:~camptocamp/account-invoicing/account-analytic-required-vre into lp:~account-core-editors/account-invoicing/7.0

[Vincent Renaville@camptocamp]

Hello,

The account_invoice_analytic_required force the user to specify an analytic account on invoice line

Vincent

[Holger Brunn (Therp) (hbrunn)]

#60 sale.invoice.line?
#104 _description is not necessary here
#180ff you should remove translation files that don't actually contain translations

And per default, the field is only visible for analytic.group_analytic_accounting. I think this addon should remove this group from the view definition.

review: Needs Fixing (code review)

[Lorenzo Battistini (elbati)]

Thanks Vincent,

some style fixes:

account_invoice_analytic_required/__init__.py:3:2: W291 trailing whitespace
account_invoice_analytic_required/__init__.py:19:75: W291 trailing whitespace
account_invoice_analytic_required/__init__.py:23:14: E271 multiple spaces after keyword
account_invoice_analytic_required/__openerp__.py:3:2: W291 trailing whitespace
account_invoice_analytic_required/__openerp__.py:19:75: W291 trailing whitespace
account_invoice_analytic_required/__openerp__.py:23:1: O603 Manifest "license" key is missing
account_invoice_analytic_required/__openerp__.py:24:11: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:25:14: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:26:15: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:28:13: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:29:14: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:30:14: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:32:11: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:33:11: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:34:11: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:35:18: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:36:19: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:37:18: E203 whitespace before ':'
account_invoice_analytic_required/account_invoice_analytic_required.py:23:1: O603 Manifest "license" key is missing
account_invoice_analytic_required/account_invoice_analytic_required.py:25:1: E302 expected 2 blank lines, found 1
account_invoice_analytic_required/account_invoice_analytic_required.py:27:13: E225 missing whitespace around operator

account_invoice_analytic_required/__openerp__.py:24:80: E501 line too long (84 > 79 characters)
account_invoice_analytic_required/__openerp__.py:27:80: E501 line too long (94 > 79 characters)
account_invoice_analytic_required/account_invoice_analytic_required.py:30:80: E501 line too long (110 > 79 characters)

review: Needs Fixing

[Pedro Manuel Baeza (pedro.baeza)]

This project is now hosted on https://github.com/OCA/account-invoicing. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Unmerged revisions

47. By Vincent Renaville@camptocamp on 2014-05-09

[ADD] account_invoice_analytic_required : this modules force the user to specificed a analytic account on invoice line

=== added directory 'account_invoice_analytic_required'
=== added file 'account_invoice_analytic_required/__init__.py'
--- account_invoice_analytic_required/__init__.py	1970-01-01 00:00:00 +0000
+++ account_invoice_analytic_required/__init__.py	2014-05-09 12:02:43 +0000
@@ -0,0 +1,23 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#    
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).
+#    Copyright (c) 2014 Camptocamp SA (http://www.camptocamp.com)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.     
+#
+##############################################################################
+
+from . import  account_invoice_analytic_required
 
=== added file 'account_invoice_analytic_required/__openerp__.py'
--- account_invoice_analytic_required/__openerp__.py	1970-01-01 00:00:00 +0000
+++ account_invoice_analytic_required/__openerp__.py	2014-05-09 12:02:43 +0000
@@ -0,0 +1,38 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#    
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).
+#    Copyright (c) 2014 Camptocamp SA (http://www.camptocamp.com)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.     
+#
+##############################################################################
+
+{
+    'name' : 'Make Account invoice analytic account required in sale.invoice.line.',
+    'version' : '1.0',
+    'category' : 'Generic Modules/Accounting',
+    'description': '''Module to make analytic account field required in sale.invoice.line.''',
+    'author' : 'OpenERP SA/Camptocamp SA',
+    'website' : 'http://www.camptocamp.com',
+    'depends' : ['base',
+                 'account'],
+    'data' : [],
+    'demo' : [],
+    'test' : [],
+    'installable' : True,
+    'auto_install' : False,
+    'application' : True,
+}
 
=== added file 'account_invoice_analytic_required/account_invoice_analytic_required.py'
--- account_invoice_analytic_required/account_invoice_analytic_required.py	1970-01-01 00:00:00 +0000
+++ account_invoice_analytic_required/account_invoice_analytic_required.py	2014-05-09 12:02:43 +0000
@@ -0,0 +1,31 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).
+#    Copyright (c) 2014 Camptocamp SA (http://www.camptocamp.com)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import orm, fields
+
+class account_invoice_line(orm.Model):
+    _name = 'account.invoice.line'
+    _inherit='account.invoice.line'
+    _description = 'Invoice line'
+    _columns = {
+        'account_analytic_id': fields.many2one('account.analytic.account', 'Analytic Account', required=True),
+    }
 
=== added directory 'account_invoice_analytic_required/i18n'
=== added file 'account_invoice_analytic_required/i18n/account_invoice_analytic_required.pot'
--- account_invoice_analytic_required/i18n/account_invoice_analytic_required.pot	1970-01-01 00:00:00 +0000
+++ account_invoice_analytic_required/i18n/account_invoice_analytic_required.pot	2014-05-09 12:02:43 +0000
@@ -0,0 +1,27 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* account_invoice_analytic_required
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 5.0.6\n"
+"Report-Msgid-Bugs-To: [e-mail]\n"
+"POT-Creation-Date: 2009-11-24 13:15:30+0000\n"
+"PO-Revision-Date: 2009-11-24 13:15:30+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: account_invoice_analytic_required
+#: model:ir.module.module,shortdesc:account_invoice_analytic_required.module_meta_information
+msgid "Account invoice analytic required"
+msgstr ""
+
+#. module: account_invoice_analytic_required
+#: model:ir.module.module,description:account_invoice_analytic_required.module_meta_information
+msgid "Module to make analytic account field required in sale.invoice.line."
+msgstr ""
+
 
=== added file 'account_invoice_analytic_required/i18n/es.po'
--- account_invoice_analytic_required/i18n/es.po	1970-01-01 00:00:00 +0000
+++ account_invoice_analytic_required/i18n/es.po	2014-05-09 12:02:43 +0000
@@ -0,0 +1,30 @@
+# Spanish translation for openobject-addons
+# Copyright (c) 2011 Rosetta Contributors and Canonical Ltd 2011
+# This file is distributed under the same license as the openobject-addons package.
+# FIRST AUTHOR <EMAIL@ADDRESS>, 2011.
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: openobject-addons\n"
+"Report-Msgid-Bugs-To: FULL NAME <EMAIL@ADDRESS>\n"
+"POT-Creation-Date: 2009-11-24 13:15+0000\n"
+"PO-Revision-Date: 2011-02-15 15:01+0000\n"
+"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
+"Language-Team: Spanish <[e-mail]>\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"X-Launchpad-Export-Date: 2011-08-13 05:35+0000\n"
+"X-Generator: Launchpad (build 13674)\n"
+
+#. module: account_invoice_analytic_required
+#: model:ir.module.module,shortdesc:account_invoice_analytic_required.module_meta_information
+msgid "Account invoice analytic required"
+msgstr "Requerida cuenta analítica en factura"
+
+#. module: account_invoice_analytic_required
+#: model:ir.module.module,description:account_invoice_analytic_required.module_meta_information
+msgid "Module to make analytic account field required in sale.invoice.line."
+msgstr ""
+"Módulo para hacer que la cuenta analítica sea requerida en la línea de "
+"factura"
 
=== added file 'account_invoice_analytic_required/i18n/fr_BE.po'
--- account_invoice_analytic_required/i18n/fr_BE.po	1970-01-01 00:00:00 +0000
+++ account_invoice_analytic_required/i18n/fr_BE.po	2014-05-09 12:02:43 +0000
@@ -0,0 +1,27 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* account_invoice_analytic_required
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 5.0.6\n"
+"Report-Msgid-Bugs-To: [e-mail]\n"
+"POT-Creation-Date: 2009-11-24 13:15:30+0000\n"
+"PO-Revision-Date: 2009-11-24 13:15:30+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: account_invoice_analytic_required
+#: model:ir.module.module,shortdesc:account_invoice_analytic_required.module_meta_information
+msgid "Account invoice analytic required"
+msgstr ""
+
+#. module: account_invoice_analytic_required
+#: model:ir.module.module,description:account_invoice_analytic_required.module_meta_information
+msgid "Module to make analytic account field required in sale.invoice.line."
+msgstr ""
+
 
=== added file 'account_invoice_analytic_required/i18n/sv.po'
--- account_invoice_analytic_required/i18n/sv.po	1970-01-01 00:00:00 +0000
+++ account_invoice_analytic_required/i18n/sv.po	2014-05-09 12:02:43 +0000
@@ -0,0 +1,27 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* account_invoice_analytic_required
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 5.0.14\n"
+"Report-Msgid-Bugs-To: [e-mail]\n"
+"POT-Creation-Date: 2009-11-24 13:15+0000\n"
+"PO-Revision-Date: 2011-02-15 15:01+0000\n"
+"Last-Translator: Olivier Dony (OpenERP) <Unknown>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"X-Launchpad-Export-Date: 2011-08-13 05:35+0000\n"
+"X-Generator: Launchpad (build 13674)\n"
+
+#. module: account_invoice_analytic_required
+#: model:ir.module.module,shortdesc:account_invoice_analytic_required.module_meta_information
+msgid "Account invoice analytic required"
+msgstr ""
+
+#. module: account_invoice_analytic_required
+#: model:ir.module.module,description:account_invoice_analytic_required.module_meta_information
+msgid "Module to make analytic account field required in sale.invoice.line."
+msgstr "Module to make analytic account field required in sale.invoice.line."