Merge lp:~camptocamp/account-invoice-report/7.0-invoice-webkit-hide-identical-ref into lp:~account-core-editors/account-invoice-report/7.0

[Guewen Baconnier @ Camptocamp]

do not display the reference if is it the same than the name (when an invoice is generated from the sales orders, it is copied in both fields)

Hide the "Your Reference" field when it is equal to the subject of the invoice.

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Guewen,

How is the result when you remove that column? Isn't odd?

Regards.

review: Needs Information

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> Hi, Guewen,
>
> How is the result when you remove that column? Isn't odd?
>
> Regards.

No, the table always takes 100% of the space.

[Pedro Manuel Baeza (pedro.baeza)]

OK then

Regards.

review: Approve (code review)

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

LGTM

review: Approve (code review, no tests)

=== modified file 'invoice_webkit/report/account_invoice.mako'
--- invoice_webkit/report/account_invoice.mako	2014-01-24 14:28:51 +0000
+++ invoice_webkit/report/account_invoice.mako	2014-03-05 12:05:30 +0000
@@ -278,7 +278,7 @@
             <th style="text-align:center;width:120px;">${_("Responsible")}</td>
             <th style="text-align:center">${_("Payment Term")}</td>
             <th style="text-align:center">${_("Our reference")}</td>
-            %if inv.reference:
+            %if inv.reference and inv.reference != inv.name:
                 <th style="text-align:center">${_("Your reference")}</td>
             %endif
         </tr>
@@ -288,7 +288,7 @@
             <td style="text-align:center;width:120px;">${inv.user_id and inv.user_id.name or ''}</td>
             <td style="text-align:center">${inv.payment_term and inv.payment_term.note or ''}</td>
             <td style="text-align:center">${inv.origin or ''}</td>
-            %if inv.reference:
+            %if inv.reference and inv.reference != inv.name:
                 <td style="text-align:center">${inv.reference}</td>
             %endif
         </tr>