Merge lp:~camptocamp/account-financial-tools/6.1-fix-1276998 into lp:~account-core-editors/account-financial-tools/6.1

[Yannick Vaucher @ Camptocamp]

[Pedro Manuel Baeza (pedro.baeza)]

Why do you put self.logger?

Usual practice is to declare one variable:

logger = logging.get(self.__name__)

And then use it.

Regards.

review: Needs Fixing (code review)

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

I'm just using the self.logger which is instantiated in Currency_rate_update_service class.

This fix is a simple fix to restore currency_rate_update which is broken.

[lp:~camptocamp/account-financial-tools/6.1-fix-1276998]

109. By Yannick Vaucher @ Camptocamp on 2014-02-06

[FIX] replace netsvc notifyChannel by logger.info and remove import of netsvc

[Pedro Manuel Baeza (pedro.baeza)]

OK then, I don't see that instantiation on MP, so my question was by that.

Regards.

review: Approve (code review)

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

line 55 could use self.logger.error(error_msg) (ie. change the logging level and use a more informative message)

review: Approve (code review, no test)

[Alexis de Lattre (alexis-via)]

review: Approve (code review and tests with openerp 6.1)

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

I fast tracked this one and merged it a moment ago.

=== modified file 'currency_rate_update/currency_rate_update.py'
--- currency_rate_update/currency_rate_update.py	2013-09-17 18:12:30 +0000
+++ currency_rate_update/currency_rate_update.py	2014-02-06 11:45:49 +0000
@@ -45,7 +45,7 @@
 from osv import osv, fields
 import time
 from datetime import datetime, timedelta
-import netsvc
+import logging
 from tools.translate import _
 
 class Currency_rate_update_service(osv.osv):
@@ -128,7 +128,6 @@
     }
 
     logger = logging.getLogger(__name__)
-    LOG_NAME = 'cron-rates'
     MOD_NAME = 'currency_rate_update: '
     def get_cron_id(self, cr, uid, context):
         """return the updater cron's id. Create one if the cron does not exists """
@@ -150,11 +149,7 @@
                                     )
             cron_id = int(cron_id[0])
         except Exception, e :
-            self.logger.notifyChannel(
-                                        self.LOG_NAME,
-                                        netsvc.LOG_INFO,
-                                        'warning cron not found one will be created'
-                                     )
+            self.logger.info('warning cron not found one will be created')
             pass  # ignore if the cron is missing cause we are going to create it in db
 
         # the cron does not exists
@@ -189,13 +184,13 @@
             # we fetch the main currency. The main rate should be set at  1.00
             main_curr = comp.currency_id.name
             for service in comp.services_to_use :
-                logger.debug("comp.services_to_use = %s" % (comp.services_to_use))
+                self.logger.debug("comp.services_to_use = %s" % (comp.services_to_use))
                 note = service.note or ''
                 try :
                     # # we initalize the class that will handle the request
                     # # and return a dict of rate
                     getter = factory.register(service.service)
-                    logger.debug("getter = %s" % (type(getter)))
+                    self.logger.debug("getter = %s" % (type(getter)))
                     curr_to_fetch = map(lambda x : x.name, service.currency_to_update)
                     res, log_info = getter.get_updated_currency(curr_to_fetch, main_curr, service.max_delta_days)
                     rate_name = time.strftime('%Y-%m-%d')
@@ -227,7 +222,7 @@
                 except Exception, e:
                     error_msg = note + "\n%s ERROR : %s"\
                         % (datetime.strftime(datetime.today(), '%Y-%m-%d %H:%M:%S'), str(e))
-                    self.logger.notifyChannel(self.LOG_NAME, netsvc.LOG_INFO, str(e))
+                    self.logger.info(str(e))
                     service.write({'note':error_msg})