Merge lp:~bzoltan/ubuntu-weather-app/fix-for-qtc into lp:ubuntu-weather-app/obsolete.trunk

Proposed by Zoltan Balogh
Status: Rejected
Rejected by: David Planella
Proposed branch: lp:~bzoltan/ubuntu-weather-app/fix-for-qtc
Merge into: lp:ubuntu-weather-app/obsolete.trunk
Diff against target: 34 lines (+3/-2)
3 files modified
ubuntu-weather-app.desktop (+1/-0)
ubuntu-weather-app.qml (+1/-1)
ubuntu-weather-app.qmlproject (+1/-1)
To merge this branch: bzr merge lp:~bzoltan/ubuntu-weather-app/fix-for-qtc
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Michael Hall Pending
Review via email: mp+159608@code.launchpad.net

Commit message

Fix project to work better with the QtCreator

Description of the change

Fix project to work better with the QtCreator:
1. added applicationName: "ubuntu-weather-app" to the MainView
2. renamed the main QML to ubuntu-weather-app.qml
3. renamed the QML project file to ubuntu-weather-app.qmlproject

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~bzoltan/ubuntu-weather-app/fix-for-qtc/+merge/159608/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

All the changes except for one are now in trunk. Zoltan submitted the final change as a separate branch on: https://code.launchpad.net/~bzoltan/ubuntu-weather-app/fix_project_name/+merge/160663

Unmerged revisions

7. By Zoltan Balogh

fix project to work better with the QtCreator

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ubuntu-weather-app.desktop'
--- ubuntu-weather-app.desktop 2013-02-12 16:27:32 +0000
+++ ubuntu-weather-app.desktop 2013-04-18 11:57:28 +0000
@@ -6,3 +6,4 @@
6Exec=/usr/bin/ubuntu-weather-app6Exec=/usr/bin/ubuntu-weather-app
7Icon=/usr/share/ubuntu-weather-app/weather64.png7Icon=/usr/share/ubuntu-weather-app/weather64.png
8Name=Weather8Name=Weather
9X-Ubuntu-Touch=true
910
=== renamed file 'weather.qml' => 'ubuntu-weather-app.qml'
--- weather.qml 2013-03-28 15:16:05 +0000
+++ ubuntu-weather-app.qml 2013-04-18 11:57:28 +0000
@@ -12,7 +12,7 @@
12MainView {12MainView {
13 // objectName for functional testing purposes (autopilot-qt5)13 // objectName for functional testing purposes (autopilot-qt5)
14 objectName: "weather"14 objectName: "weather"
15 15 applicationName: "ubuntu-weather-app"
16 width: units.gu(50)16 width: units.gu(50)
17 height: units.gu(75)17 height: units.gu(75)
18 18
1919
=== renamed file 'weather.qmlproject' => 'ubuntu-weather-app.qmlproject'
--- weather.qmlproject 2013-02-12 16:27:32 +0000
+++ ubuntu-weather-app.qmlproject 2013-04-18 11:57:28 +0000
@@ -3,7 +3,7 @@
3import QmlProject 1.13import QmlProject 1.1
44
5Project {5Project {
6 mainFile: "weather.qml"6 mainFile: "ubuntu-weather-app.qml"
77
8 /* Include .qml, .js, and image files from current directory and subdirectories */8 /* Include .qml, .js, and image files from current directory and subdirectories */
9 QmlFiles {9 QmlFiles {

Subscribers

People subscribed via source and target branches