Merge lp:~brunoqc/ubuntu/natty/lfm/lfm-fix-786491 into lp:ubuntu/natty/lfm

Proposed by Bruno Bigras
Status: Merged
Merge reported by: Martin Pitt
Merged at revision: not available
Proposed branch: lp:~brunoqc/ubuntu/natty/lfm/lfm-fix-786491
Merge into: lp:ubuntu/natty/lfm
Diff against target: 60 lines (+41/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/fix-lp786491.patch (+34/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~brunoqc/ubuntu/natty/lfm/lfm-fix-786491
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Ubuntu branches Pending
Review via email: mp+77859@code.launchpad.net

Description of the change

Fix 786491 (this time with the actual patch)

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Good work, thanks! I took the liberty of running 'update-maintainer' (https://wiki.ubuntu.com/DebianMaintainerField) and uploaded it, so it should be sitting in the SRU review queue now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2010-05-24 16:55:24 +0000
+++ debian/changelog 2011-10-03 05:44:24 +0000
@@ -1,3 +1,9 @@
1lfm (2.2-1ubuntu0.11.04.1) natty-proposed; urgency=low
2
3 * Fix a crash at startup, because of UnicodeDecodeError (LP: #786491)
4
5 -- Bruno Bigras <bigras.bruno@gmail.com> Sat, 17 Sep 2011 22:19:56 -0400
6
1lfm (2.2-1) unstable; urgency=low7lfm (2.2-1) unstable; urgency=low
28
3 * New Upstream release.9 * New Upstream release.
410
=== added file 'debian/patches/fix-lp786491.patch'
--- debian/patches/fix-lp786491.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/fix-lp786491.patch 2011-10-03 05:44:24 +0000
@@ -0,0 +1,34 @@
1Description: Fix an UnicodeDecodeError by using decode() instead of str()
2Origin: upstream, https://bitbucket.org/inigoserna/lfm/changeset/8d2021770794
3Forwarded: not-needed
4Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/lfm/+bug/786491
5Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=617229
6Index: lfm-2.2/lfm/files.py
7===================================================================
8--- lfm-2.2.orig/lfm/files.py 2011-09-17 22:07:32.049362240 -0400
9+++ lfm-2.2/lfm/files.py 2011-09-17 22:08:21.719435092 -0400
10@@ -152,11 +152,11 @@
11 try:
12 owner = pwd.getpwuid(st[stat.ST_UID])[0]
13 except:
14- owner = str(st[stat.ST_UID])
15+ owner = decode(st[stat.ST_UID])
16 try:
17 group = grp.getgrgid(st[stat.ST_GID])[0]
18 except:
19- group = str(st[stat.ST_GID])
20+ group = decode(st[stat.ST_GID])
21 return (typ, stat.S_IMODE(st[stat.ST_MODE]), owner, group,
22 size, st[stat.ST_MTIME])
23
24@@ -228,8 +228,8 @@
25 else:
26 mtime = time.strftime('%a %d %b %Y', time.localtime(filevalues[FT_MTIME]))
27 mtime2 = time.strftime('%d %b %Y', time.localtime(filevalues[FT_MTIME]))
28- res['mtime'] = mtime
29- res['mtime2'] = mtime2
30+ res['mtime'] = decode(mtime)
31+ res['mtime2'] = decode(mtime2)
32 return res
33
34
035
=== modified file 'debian/patches/series'
--- debian/patches/series 2010-05-24 16:55:24 +0000
+++ debian/patches/series 2011-10-03 05:44:24 +0000
@@ -1,2 +1,3 @@
1ignore_COPYING.patch1ignore_COPYING.patch
2debian-changes-2.2-12debian-changes-2.2-1
3fix-lp786491.patch

Subscribers

People subscribed via source and target branches

to all changes: