Merge lp:~brandontschaefer/unity/fix-915828 into lp:unity
Proposed by
Brandon Schaefer
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Tim Penhey | ||||||||
Approved revision: | no longer in the source branch. | ||||||||
Merged at revision: | 1962 | ||||||||
Proposed branch: | lp:~brandontschaefer/unity/fix-915828 | ||||||||
Merge into: | lp:unity | ||||||||
Diff against target: |
46 lines (+17/-0) 3 files modified
manual-tests/Dash.txt (+12/-0) plugins/unityshell/src/IMTextEntry.cpp (+4/-0) plugins/unityshell/src/IMTextEntry.h (+1/-0) |
||||||||
To merge this branch: | bzr merge lp:~brandontschaefer/unity/fix-915828 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | Approve | ||
Thomi Richards (community) | Needs Fixing | ||
Sam Spilsbury (community) | Approve | ||
Review via email: mp+88450@code.launchpad.net |
Description of the change
Fixes the gtk-im-context not getting focused when the dash is opened. A signal from nux was removed causing this; couldn't find one to replace it. So using a property bool when the dash is about to show to call OnFocusIn(); when it is hiding OnFocusOut().
Not sure if I should have exposed those two functions in IMTextEntry.h, if that is not wanted I can add another property bool in IMTextEntry.cpp and use that focus in and out.
To post a comment you must log in.
Is it possible to make DashView, DashSearchBar and IMEntry use named constructors ? In that case, you can create an DashView and DashSearchBar shared ptr and then pass that to the IMEntry constructor, then assign the IMEntry object to the DashSearchBar.