Merge lp:~blake-rouse/maas/fix-1514883 into lp:~maas-committers/maas/trunk
Proposed by
Blake Rouse
Status: | Merged |
---|---|
Approved by: | Blake Rouse |
Approved revision: | no longer in the source branch. |
Merged at revision: | 4487 |
Proposed branch: | lp:~blake-rouse/maas/fix-1514883 |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
145 lines (+98/-2) 2 files modified
src/provisioningserver/rpc/boot_images.py (+26/-0) src/provisioningserver/rpc/tests/test_boot_images.py (+72/-2) |
To merge this branch: | bzr merge lp:~blake-rouse/maas/fix-1514883 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mike Pontillo (community) | Approve | ||
Review via email: mp+277201@code.launchpad.net |
Commit message
Replace the URL provided from the region with the maas_url from the cluster configuration file. This will make sure that the cluster uses the same URL to connect for RPC for downloading boot images.
To post a comment you must log in.
Just a few minor issues/suggestions:
- Format imports. for_cluster to pull out URL replacement logic.
- Refactor fix_sources_
- Add tests for more edge cases in URL replacement logic.