Merge lp:~black-perl/mailman/handling-special-chars-in-email into lp:mailman

[Ankush Sharma]

In case the mailman-client percent encodes any special character appeared in the list_id's or fqdn_listname's, the REST server should be able to decode it back. Added decoding support for it.
As discussed here: http://www.mail-archive.com/mailman-developers%40python.org/msg15317.html
Now mailman can also use emails with special characters [1] which earlier caused postorius to crash as discussed in the linked bug report.

[1] : http://oi58.tinypic.com/33u689i.jpg

[Barry Warsaw (barry)]

Could you please add a test for this case, and port your branch over to gitlab:

https://gitlab.com/mailman/mailman

Thanks!

review: Needs Fixing

[Ankush Sharma (black-perl)]

Actually, discussed the bug with florianf. The endoded endpoint has to be decoded on the "core" end and therefore I did the patch in mailman-core. But, later I get to know that Falcon is smart and automatically decodes any encoded character in the URL. Therefore, I guess the "core" patch can be closed.

[Barry Warsaw (barry)]

Thanks!

Unmerged revisions

7304. By black-perl <email address hidden> on 2015-03-13

Added decoding support for the list identifier as per the fix for the issue #1429366.

=== modified file 'src/mailman/rest/root.py'
--- src/mailman/rest/root.py	2015-02-13 08:13:06 +0000
+++ src/mailman/rest/root.py	2015-03-13 09:28:31 +0000
@@ -23,6 +23,7 @@
 
 
 import falcon
+import urllib.parse
 
 from base64 import b64decode
 from mailman.config import config
@@ -192,7 +193,9 @@
         else:
             # list-id is preferred, but for backward compatibility,
             # fqdn_listname is also accepted.
-            list_identifier = segments.pop(0)
+            enc_list_identifier = segments.pop(0)
+            # decoding the percent encoded list_identifier
+            list_identifier = urllib.parse.unquote(enc_list_identifier)
             return AList(list_identifier), segments
 
     @child()